Keymgmt-Updates and Bugfixes #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-by: Grgo.Mariani <[email protected]> Signed-off-by: Holger Dengler <[email protected]>
Signed-off-by: Holger Dengler <[email protected]>
The key management functions should be registered with their names and an Object Identifier (OID), so that they can be found by the lookup processing. Signed-off-by: Holger Dengler <[email protected]>
The key type should be either the short/long name or the OID. Use the short name for RSA and EC keys. Signed-off-by: Holger Dengler <[email protected]>
ifranzki
reviewed
Jun 4, 2025
Remove all explicit cleanups in pkcs11_module_load(), as the cleanup is done by the teardown anyways. While at it, add error handling for string duplications. Signed-off-by: Holger Dengler <[email protected]>
ifranzki
approved these changes
Jun 4, 2025
|
I'll remove the gh action commit for now and try to cover it in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor changes/updates as well as a fix for two bugs (double-free). It also corrects the the key management registration and key typing.