Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] tools-v2: add snapshot-clone-status #2442

Merged
merged 1 commit into from
May 8, 2023
Merged

[feat] tools-v2: add snapshot-clone-status #2442

merged 1 commit into from
May 8, 2023

Conversation

Xinlong-Chen
Copy link
Contributor

What problem does this PR solve?

Issue Number: #2346

Problem Summary: support bs status snapshot command in curve tool

What is changed and how it works?

What's Changed:

  1. add snapshot command(snapshot.go) in curve/tools-v2/pkg/cli/command/curvebs/status (also modify some code style in etcd.go and mds.go).
  2. add new command reference in tools-v2/pkg/cli/command/curvebs/status/status.go.
  3. add snapshot clone config in config file(tools-v2/pkg/config) and modify the user config file.

How it Works: using command curve bs status snapshot

Side effects(Breaking backward compatibility? Performance regression?): just client
the result in tools-v1:

SnapshotCloneServer status:
version: 9.9.9+2c4861ca
current snapshot-clone-server: 192.168.20.149:5550
online snapshot-clone-server list: 192.168.20.149:5550, 192.168.20.149:5551, 192.168.20.149:5552
offline snapshot-clone-server list:

the result in tools-v2:

+---------------------+---------------------+----------------+----------+
|        ADDR         |      DUMMYADDR      |    VERSION     |  STATUS  |
+---------------------+---------------------+----------------+----------+
| 192.168.20.149:5551 | 192.168.20.149:8101 | 9.9.9+2c4861ca | follower |
+---------------------+---------------------+                +          +
| 192.168.20.149:5552 | 192.168.20.149:8102 |                |          |
+---------------------+---------------------+                +----------+
| 192.168.20.149:5550 | 192.168.20.149:8100 |                | leader   |
+---------------------+---------------------+----------------+----------+

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

test success now! please take a look, thx.

@Xinlong-Chen
Copy link
Contributor Author

Anyone else to cr this pr?

@Xinlong-Chen Xinlong-Chen force-pushed the snapshot-status-2 branch 2 times, most recently from 59b61c3 to 6f88e53 Compare April 27, 2023 10:47
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

Cyber-SiKu
Cyber-SiKu reviewed May 4, 2023
View reviewed changes
tools-v2/README.md Outdated Show resolved Hide resolved
tools-v2/pkg/config/bs.go Outdated Show resolved Hide resolved
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@Cyber-SiKu here, please have a look again...

aspirer
aspirer reviewed May 5, 2023
View reviewed changes
tools-v2/README.md Outdated Show resolved Hide resolved
tools-v2/pkg/config/curve.yaml Outdated Show resolved Hide resolved
tools-v2/README.md Outdated Show resolved Hide resolved
@Xinlong-Chen Xinlong-Chen force-pushed the snapshot-status-2 branch 2 times, most recently from 1b52c83 to fbdd64d Compare May 5, 2023 12:21
@Xinlong-Chen
Copy link
Contributor Author

cicheck

1 similar comment
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Cyber-SiKu Cyber-SiKu merged commit eb88442 into opencurve:master May 8, 2023
@Xinlong-Chen Xinlong-Chen deleted the snapshot-status-2 branch May 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspirer aspirer aspirer left review comments

@Cyber-SiKu Cyber-SiKu Cyber-SiKu approved these changes

@wu-hanqing wu-hanqing wu-hanqing approved these changes

Assignees
No one assigned
Labels
Developer Activities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xinlong-Chen @aspirer @wu-hanqing @Cyber-SiKu @zhanghuidinah