Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] tools-v2: add do-snapshot #2454

Merged
merged 1 commit into from
May 10, 2023

Conversation

Xinlong-Chen
Copy link
Contributor

@Xinlong-Chen Xinlong-Chen commented Apr 28, 2023

What problem does this PR solve?

Issue Number: #2023

Problem Summary: add command curve bs snapshot one

What is changed and how it works?

What's Changed:

  1. add tools-v2/pkg/cli/command/curvebs/snapshot/snapshot.go
  2. add tools-v2/pkg/cli/command/curvebs/snapshot/one/one.go
  3. modify tools-v2/pkg/cli/command/curvebs/bs.go

How it Works:
implement by using rpc snapshot

$ curve bs snapshot one 192.168.20.149:8201:0 --logicalpoolid=1 --copysetid=10                                                   1 ↵
+-----------------------+---------+---------+--------+
|         PEER          | COPYSET | RESULT  | REASON |
+-----------------------+---------+---------+--------+
| 192.168.20.149:8201:0 | (1:10)  | success | null   |
+-----------------------+---------+---------+--------+

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the do-snapshot-2 branch 5 times, most recently from 057de9b to 70f483c Compare May 7, 2023 03:29
@Xinlong-Chen
Copy link
Contributor Author

cicheck

1 similar comment
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Cyber-SiKu
Copy link
Contributor

curve bs snapshot copyset is better?

@Xinlong-Chen Xinlong-Chen force-pushed the do-snapshot-2 branch 2 times, most recently from 2bb9918 to 99d7260 Compare May 10, 2023 10:14
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the do-snapshot-2 branch 2 times, most recently from 492fd11 to 2cdcd36 Compare May 10, 2023 12:22
@Xinlong-Chen
Copy link
Contributor Author

cicheck

tools-v2/pkg/cli/command/curvebs/snapshot/one/one.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/snapshot/one/one.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/snapshot/snapshot.go Outdated Show resolved Hide resolved
tools-v2/pkg/cli/command/curvebs/snapshot/snapshot.go Outdated Show resolved Hide resolved
@Cyber-SiKu
Copy link
Contributor

cicheck

@Xinlong-Chen Xinlong-Chen merged commit 3aa7435 into opencurve:master May 10, 2023
@Xinlong-Chen Xinlong-Chen deleted the do-snapshot-2 branch May 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants