Feat: add zap log print #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengshunli
force-pushed
the
zap
branch
4 times, most recently
from
4d23281 to
6aaca62
Compare
Cyber-SiKu
reviewed
May 19, 2023
| @@ -1,3 +1,4 @@ | |||
| //go:build debug | |||
| @@ -1,3 +1,4 @@ | |||
| //go:build !debug | |||
pkg/log/zaplog/log.go
Outdated
Comment on lines
128
to
132
| Filename: logpath, // 日志文件的位置 | ||
| MaxSize: 10, // 在进行切割之前，日志文件的最大大小（以MB为单位） | ||
| MaxBackups: 200, // 保留旧文件的最大个数 | ||
| MaxAge: 30, // 保留旧文件的最大天数 | ||
| Compress: true, // 是否压缩/归档旧文件 |
| log.Field("LogPath", logpath), | ||
| log.Field("LogLevel", config.GetLogLevel())) | ||
| } | ||
| logpath := fmt.Sprintf("%s/curveadm.log", curveadm.logDir) |
There was a problem hiding this comment.
Why is the date-related information removed from the log name?
There was a problem hiding this comment.
The content of the same file reaches the specified number to be compressed. Passing the date will result in too many small files and cannot be cleared
cli/cli/cli.go
Outdated
| @@ -148,17 +145,17 @@ func (curveadm *CurveAdm) init() error { | |||
| dbpath := fmt.Sprintf("%s/curveadm.db", curveadm.dataDir) | |||
| s, err := storage.NewStorage(dbpath) | |||
| if err != nil { | |||
| log.Error("Init SQLite database failed", | |||
| log.Field("Error", err)) | |||
| zaplog.LOG.Error("Init SQLite database failed", | |||
There was a problem hiding this comment.
You can avoid directly exposing the variable LOG by adding functions in zaplog.go, which can also be used in the same way as the original, such as zaplog.Info(), zaplog.Error() and other functions.
| @@ -41,7 +42,7 @@ import ( | |||
| tui "github.com/opencurve/curveadm/internal/tui/common" | |||
| "github.com/opencurve/curveadm/internal/utils" | |||
| cliutil "github.com/opencurve/curveadm/internal/utils" | |||
| log "github.com/opencurve/curveadm/pkg/log/glg" | |||
| "github.com/opencurve/curveadm/pkg/log/zaplog" | |||
There was a problem hiding this comment.
Suggested change
| "github.com/opencurve/curveadm/pkg/log/zaplog" | |
| log "github.com/opencurve/curveadm/pkg/log/zaplog" |
This can keeps your changes small.
Signed-off-by: fengshunli <[email protected]>
|
There are some conflicts that can be resolved |
|
see #233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.