Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: Skip fuse check when kernel is WSL2 #319

Open
wants to merge 1 commit into
base: tombstone
Choose a base branch
from
Open

[Fix]: Skip fuse check when kernel is WSL2 #319

wants to merge 1 commit into from
+22 −0

Conversation

NaturalSelect
Copy link

What this PR does:

  • FUSE is statically compiled into the WSL2 kernel, so modinfo is not applicable in WSL2.
  • If we deploy client on WSL2, skip FUSE module check.

See also: WSL Issue.

caoxianfei1
caoxianfei1 reviewed Oct 23, 2023
View reviewed changes
internal/task/step/shell.go
@@ -475,6 +476,15 @@ func (s *UnixName) Execute(ctx *context.Context) error {
}

func (s *ModInfo) Execute(ctx *context.Context) error {
isWsl2, err := ctx.Module().Shell().IsWsl2()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate step is better？

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caoxianfei1 caoxianfei1 caoxianfei1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NaturalSelect @caoxianfei1