Skip to content

Fix some grid_spec warnings #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Mar 31, 2025

Make a private function that
extracts the same product information
that was previously gotten from
the now deprecated grid_spec,
and then use that helper instead
of grid_spec.

The helper should be removed once
there are suitable replacements
in some part of the opendatacube-API.


📚 Documentation preview 📚: https://datacube-explorer--658.org.readthedocs.build/en/658/

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (7d933f4) to head (e4db2ac).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
cubedash/summary/_extents.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #658      +/-   ##
===========================================
+ Coverage    89.26%   89.57%   +0.30%     
===========================================
  Files           34       34              
  Lines         4119     4229     +110     
===========================================
+ Hits          3677     3788     +111     
+ Misses         442      441       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjonsson pjonsson force-pushed the fix-deprecation-grid-spec branch 3 times, most recently from 0ae3cc4 to b691b3d Compare March 31, 2025 14:37
@pjonsson pjonsson changed the title summary: get resolution without grid_spec Fix some grid_spec warnings Mar 31, 2025
@pjonsson
Copy link
Contributor Author

This fixes 550 warnings that test_page_load triggers, 220 warnings triggered by test_stac, and a bunch of other warnings.

After this PR, it's clear that the remaining GridSpec warnings are caused by test_summarise_data.py::test_computed_regions_match_those_summarised[default].

Make a private function that
extracts the same product information
that was previously gotten from
the now deprecated grid_spec,
and then use that helper instead
of grid_spec.

The helper should be removed once
there are suitable replacements
in some part of the opendatacube-API.
@pjonsson pjonsson force-pushed the fix-deprecation-grid-spec branch from b691b3d to fc05481 Compare April 2, 2025 08:29
@pjonsson pjonsson marked this pull request as draft April 16, 2025 07:25
@pjonsson
Copy link
Contributor Author

Making this a draft since opendatacube/datacube-core#1783 revealed the resolution can be a scalar.

If the grid_spec property remains and is no longer deprecated, I think it would be better to use that than replicate the same functionality in explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants