-
Notifications
You must be signed in to change notification settings - Fork 34
Remove setuptools_scm workarounds #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
4daa040 to
402e97d
Compare
These look like things that are masking issues with packaging. Coincidentally, this also seems to reduce the "every file imports everything else" that you notice when type checking a single file.
402e97d to
ad3ea87
Compare
| @@ -1,8 +1,4 @@ | |||
| try: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these try-except are workarounds for not running an installed package. The docker image in CI is tested with installed packages*, and uv run pytest installs the package first, so this shouldn't be required any more.
*) The CI kept finding cubedash in . instead of using the installed version, so I changed import-mode of pytest, and pointed it to the integration_tests directory. I suspect these would be non-issues with a source-layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking we should switch to a source-layout too. I think it's a more rigorous structure, with the only drawback being you can run python from the repo base and have it find the package source.
I think the days are long (loooong) past where that's a useful thing to want to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was caught out recently with this repo having a docker/ directory, and it breaking import docker. :-(
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #775 +/- ##
===========================================
- Coverage 84.72% 0.00% -84.73%
===========================================
Files 34 34
Lines 4237 4231 -6
Branches 535 0 -535
===========================================
- Hits 3590 0 -3590
- Misses 460 4231 +3771
+ Partials 187 0 -187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Apparently everything breaks when trying to remove these things, so I'll get back to this later. |
These look like things that are masking
issues with packaging.
Coincidentally, this also seems to
reduce the "every file imports everything
else" that you notice when type checking
a single file.
📚 Documentation preview 📚: https://datacube-explorer--775.org.readthedocs.build/en/775/