Skip to content

Conversation

@pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Aug 5, 2025

These look like things that are masking
issues with packaging.

Coincidentally, this also seems to
reduce the "every file imports everything
else" that you notice when type checking
a single file.


📚 Documentation preview 📚: https://datacube-explorer--775.org.readthedocs.build/en/775/

@pjonsson pjonsson force-pushed the remove-version-specials branch from 4daa040 to 402e97d Compare August 5, 2025 19:09
These look like things that are masking
issues with packaging.

Coincidentally, this also seems to
reduce the "every file imports everything
else" that you notice when type checking
a single file.
@pjonsson pjonsson force-pushed the remove-version-specials branch from 402e97d to ad3ea87 Compare August 5, 2025 19:42
@@ -1,8 +1,4 @@
try:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these try-except are workarounds for not running an installed package. The docker image in CI is tested with installed packages*, and uv run pytest installs the package first, so this shouldn't be required any more.

*) The CI kept finding cubedash in . instead of using the installed version, so I changed import-mode of pytest, and pointed it to the integration_tests directory. I suspect these would be non-issues with a source-layout.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking we should switch to a source-layout too. I think it's a more rigorous structure, with the only drawback being you can run python from the repo base and have it find the package source.

I think the days are long (loooong) past where that's a useful thing to want to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was caught out recently with this repo having a docker/ directory, and it breaking import docker. :-(

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (01d163f) to head (ad3ea87).

Files with missing lines Patch % Lines
cubedash/summary/_stores.py 0.00% 6 Missing ⚠️
cubedash/__init__.py 0.00% 1 Missing ⚠️
cubedash/_pages.py 0.00% 1 Missing ⚠️
cubedash/run.py 0.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #775       +/-   ##
===========================================
- Coverage    84.72%   0.00%   -84.73%     
===========================================
  Files           34      34               
  Lines         4237    4231        -6     
  Branches       535       0      -535     
===========================================
- Hits          3590       0     -3590     
- Misses         460    4231     +3771     
+ Partials       187       0      -187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjonsson pjonsson marked this pull request as draft August 5, 2025 21:18
@pjonsson
Copy link
Contributor Author

pjonsson commented Aug 5, 2025

Apparently everything breaks when trying to remove these things, so I'll get back to this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants