Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix test-prod #1114

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Mar 26, 2025

Initialize the database with valid data, and then run the external curl tests.

Opendatacube 1.9 throws an exception when the specified config file cannot be found, so only set set ODC_CONFIG_PATH when there is a file.


📚 Documentation preview 📚: https://datacube-ows--1114.org.readthedocs.build/en/1114/

@pjonsson pjonsson force-pushed the ci-fix-prod-tests branch 3 times, most recently from 0016d2b to 84fea2b Compare March 26, 2025 17:26
@pjonsson
Copy link
Contributor Author

@omad It should be possible to revert the middle commit and fix the issue(s) at a later stage if you merge this PR without squashing. If #1112 is also merged, the CI on main should be green again.

@pjonsson pjonsson force-pushed the ci-fix-prod-tests branch from 84fea2b to 78a909f Compare March 26, 2025 17:54
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.74%. Comparing base (fabb2f7) to head (a13d5bd).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
datacube_ows/wsgi.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1114      +/-   ##
===========================================
- Coverage    93.03%   92.74%   -0.30%     
===========================================
  Files           53       53              
  Lines         7080     7081       +1     
===========================================
- Hits          6587     6567      -20     
- Misses         493      514      +21     
Files with missing lines Coverage Δ
datacube_ows/wsgi.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pjonsson pjonsson force-pushed the ci-fix-prod-tests branch from 78a909f to ace0140 Compare March 31, 2025 08:34
This was referenced Apr 1, 2025
pjonsson added 3 commits April 9, 2025 10:02
Datacube 1.9 throws an exception
when pointed to a config file
it cannot read, so only set
the environment variable if the file
exists.
This product fails with:

sqlalchemy.exc.IntegrityError: (psycopg2.errors.NotNullViolation) null value in column "lat_min" of relation "layer_ranges" violates not-null constraint
DETAIL:  Failing row contains (ga_ls_fc_3, null, null, null, null, "", "", {"env": "default", "datasets": 0, "products": ["ga_ls_fc_3"], "t..., 2025-03-26 15:33:18.356186).
Populate the database before
running the external curl tests.
@pjonsson pjonsson force-pushed the ci-fix-prod-tests branch from ace0140 to a13d5bd Compare April 9, 2025 08:04
@pjonsson pjonsson requested a review from SpacemanPaul April 9, 2025 08:24
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's merge this and clear the rest of the backlog, then I can look into what's wrong with the FC products.

@SpacemanPaul SpacemanPaul merged commit 4a793d8 into opendatacube:develop Apr 10, 2025
11 checks passed
@pjonsson pjonsson deleted the ci-fix-prod-tests branch April 10, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants