Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Interface: Moving 'About/Description' Section to the Top in ODD #1692 #1693

Merged
merged 1 commit into from
Aug 2, 2024
Merged

User Interface: Moving 'About/Description' Section to the Top in ODD #1692 #1693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions odd-platform-ui/src/components/DataEntityDetails/Overview/Overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,9 @@ const Overview: React.FC = () => {
)}
<SectionContainer square elevation={0}>
<WithPermissionsProvider
allowedPermissions={[
Permission.DATA_ENTITY_CUSTOM_METADATA_CREATE,
Permission.DATA_ENTITY_CUSTOM_METADATA_UPDATE,
Permission.DATA_ENTITY_CUSTOM_METADATA_DELETE,
]}
allowedPermissions={[Permission.DATA_ENTITY_DESCRIPTION_UPDATE]}
resourcePermissions={resourcePermissions}
Component={OverviewMetadata}
render={() => <OverviewDescription termRefs={termRefs} />}
/>
</SectionContainer>
<SectionContainer square elevation={0}>
Expand All @@ -81,14 +77,18 @@ const Overview: React.FC = () => {
Component={OverviewAttachments}
/>
</SectionContainer>
<OverviewMetrics showOverview={isDataset} />
<SectionContainer square elevation={0}>
<WithPermissionsProvider
allowedPermissions={[Permission.DATA_ENTITY_DESCRIPTION_UPDATE]}
allowedPermissions={[
Permission.DATA_ENTITY_CUSTOM_METADATA_CREATE,
Permission.DATA_ENTITY_CUSTOM_METADATA_UPDATE,
Permission.DATA_ENTITY_CUSTOM_METADATA_DELETE,
]}
resourcePermissions={resourcePermissions}
render={() => <OverviewDescription termRefs={termRefs} />}
Component={OverviewMetadata}
/>
</SectionContainer>
<OverviewMetrics showOverview={isDataset} />
</Grid>
<Grid item xs={3}>
<SectionContainer square elevation={0}>
Expand Down Expand Up @@ -156,4 +156,4 @@ const Overview: React.FC = () => {
</>
);
};
export default Overview;
export default Overview;
Loading