feat(backend): Source ObjStore Creds from Env in Tekton Template #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Unblocks opendatahub-io/data-science-pipelines-operator#151
Description of your changes:
Cherry-pick feature from upstream kubeflow#1259
Allow admins to define OBJECTSTORECONFIG_CREDENTIALS(SECRET|ACCESSKEYKEY|SECRETKEYKEY) env vars instead of the previously hardcoded
mlpipeline-minio-artifact
,accesskey
, andsecretkey
values, respectivelyEnvironment tested:
python --version
): 3.11tkn version
): 0.31kubectl version
): 1.22/etc/os-release
): Fedora 38Checklist: