[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.21.1 #719
Conversation
Signed-off-by: codeflare-machine-account <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@codeflare-machine-account: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
This doesn't update the python 3.9 images, which, I presume, is expected on this branch.
But one question - I can see that intel/runtimes/ml/... is updated but the rest of the Intel images are not:
$ grep -r "codeflare-sdk = " | grep -v "0.21.1" | grep -v "\-3.9"
jupyter/intel/pytorch/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/pytorch/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/tensorflow/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/tensorflow/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/pytorch/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/pytorch/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/tensorflow/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/tensorflow/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
First I thought, that we don't intend to touch the images from Intel as we don't maintain them. But since we touch at least one of them, we should update all, no?
I presume that the reason the others aren't updated is because the Pipfile is actually named as Pipfile.cpu or Pipfile.gpu which was discussed some time ago and the fix was supposed to be in place for this already, see project-codeflare/codeflare-sdk#645.
Looks like there was some refactor 2 weeks ago project-codeflare/codeflare-sdk#655 which broke that, see lines 61 and 79. This can be seen in the execution also, see multiple errors here:
line 5: 2: command not found
Update: I raised this one project-codeflare/codeflare-sdk#691 to fix it. I didn't try it, but I suspect that after that fix, also 3.9 images will get updated with the next round.
| @@ -4,13 +4,11 @@ verify_ssl = true | |||
| name = "pypi" | |||
|
|
|||
| [packages] | |||
| # Classical-ML | |||
There was a problem hiding this comment.
@harshad16 are we okay we're loosing these comment lines? 🤔
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@KPostOffice do you think it would be possible to close this PR and raise a new one with the latest changes applied to the relevant GHA? 🤔 |
|
As the codeflare-sdk github action failed: https://github.com/project-codeflare/codeflare-sdk/actions/runs/11134262380 |
@harshad16 The GHA failed during upgrade of this directory: I wonder - do we want to update these 3.9 python based images or can we remove that python version from the GHA and update only 3.11 based images from now on? |
🚀 This is an automated Pull Request.
This PR updates the
Pipfileto sync with latest Codeflare-SDK release.