Sync/250617 incubation main #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atahub-io#459) [RHOAIENG-25522] While the reported issue was not reproducible in the current code base, I've made an improvement in the serverless mode route deletion, it was deleting the route based on the isvc name, whereas it should be deleting based on the owner reference, similar to how raw route handling is done. Plus, a unit test was added to verify that the route is still deployed upon Inference Service deletion. Signed-off-by: Spolti <[email protected]>
…endatahub-io#444) Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: rpancham <[email protected]>
…[email protected]> Signed-off-by: Rob Geada <[email protected]>
Signed-off-by: Rob Geada <[email protected]>
…hub-io#452) * Add KEDA reconciler for raw deployment mode Integrate KEDA-based autoscaling for KServe InferenceServices in RawDeployment mode. This allows ISVCs to autoscale on custom Prometheus metrics via KEDA, with secure OpenShift Monitoring access. The reconciler automates KEDA/RBAC resource lifecycle. Key changes: - New KServeKEDAReconciler manages KEDA-specific resources (ServiceAccount, Secret, Role, RoleBinding, TriggerAuthentication) for Prometheus-based autoscaling. - Creates resources if ISVC uses Prometheus external metric. - Adds ISVC as non-controlling owner to shared resources. - Removes ISVC owner reference if KEDA metrics unused or ISVC deleted. - Cleans up KEDA resources from namespace if no ISVCs use KEDA. - InferenceService controller now: - Watches KEDA TriggerAuthentication, Role, RoleBinding. - Uses MatchEveryOwner for ServiceAccount, Secret for sharing. - Conditionally watches TriggerAuthentication if CRD present. - KEDA API (keda.sh/v1alpha1) registered with scheme. - A few tests added for KServe KEDA reconciler, covering: - Creation/ownership of KEDA resources for multiple ISVCs. - Owner reference removal on ISVC deletion/metric config change. - Handling updates to managed KEDA resources. - Scenarios with shared/unrequired KEDA resources. - Namespace cleanup. Signed-off-by: Pierangelo Di Pilato <[email protected]> * Update ClusterRole through kubebuilder tags Signed-off-by: Pierangelo Di Pilato <[email protected]> * Improve test readability - Extract HaveOwnerReferenceByUID GomegaMatcher into a reusable matcher - Extract KEDA resources fixture functions to not clutter the specs - Inline assertions Signed-off-by: Pierangelo Di Pilato <[email protected]> * Improve logging Signed-off-by: Pierangelo Di Pilato <[email protected]> * AsOwnerRef separate file Signed-off-by: Pierangelo Di Pilato <[email protected]> * Remove ctx override and unnecessary comment Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
Separate HF Detector into its own params.env file
…endatahub-io#465) * adding default behavior for setting timeout on openshift routes created for isvcs. Also adding support for overrding this defautl behavior by setting the haproxy.router.openshift.io/timeout annotation in an isvc Signed-off-by: Brett Thompson <[email protected]> * now setting openshift route timeout equal to the sum of all inference service component timeouts by default Signed-off-by: Brett Thompson <[email protected]> * no longer setting all isvc annotations in the openshift route created by the KserveRouteReconciler to avoid unneccessary route updates Signed-off-by: Brett Thompson <[email protected]> --------- Signed-off-by: Brett Thompson <[email protected]>
* update openshift template with a runtime version Signed-off-by: Edward Arthur Quarm Jnr <[email protected]> * move annotations from template to servingruntime metadata Signed-off-by: Edward Arthur Quarm Jnr <[email protected]> --------- Signed-off-by: Edward Arthur Quarm Jnr <[email protected]> Co-authored-by: Edward Arthur Quarm Jnr <[email protected]>
Signed-off-by: Brett Thompson <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
brettmthompson
added
the
tide/merge-method-merge
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brettmthompson, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post Release ODH Sync for RHOAIENG-26306
Description
How Has This Been Tested?
Merge criteria: