fix: optimize block removal logic by tracking processed indices #3239
Conversation
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the block removal logic in the remove_overlaps_low_confidence_blocks function by adding a tracking mechanism for processed block indices to avoid redundant operations.
Key changes:
- Introduces a
marked_indicesset to track blocks already marked for removal - Adds early exit conditions to skip processing of already-marked blocks
- Updates the block selection logic to only consider unprocessed blocks
| @@ -259,13 +259,19 @@ def remove_overlaps_low_confidence_blocks(combined_res_list, overlap_threshold=0 | |||
| block_info.append((xmin, ymin, xmax, ymax, area, score, block)) | |||
|
|
|||
| blocks_to_remove = [] | |||
| marked_indices = set() # 跟踪已标记为删除的block索引 | |||
There was a problem hiding this comment.
[nitpick] The comment is in Chinese. Consider using English comments for better code maintainability and consistency with the rest of the codebase.
| marked_indices = set() # 跟踪已标记为删除的block索引 | |
| marked_indices = set() # Tracks the indices of blocks marked for removal |
Copilot uses AI. Check for mistakes.
|
|
||
| # 检查每个block内部是否有3个及以上的小block | ||
| for i, (xmin, ymin, xmax, ymax, area, score, block) in enumerate(block_info): | ||
| # 查找内部的小block | ||
| # 如果当前block已标记为删除，则跳过 |
There was a problem hiding this comment.
[nitpick] The comment is in Chinese. Consider using English comments for better code maintainability and consistency with the rest of the codebase.
| # 如果当前block已标记为删除，则跳过 | |
| # Skip if the current block is already marked for removal |
Copilot uses AI. Check for mistakes.
| if i in marked_indices: | ||
| continue | ||
|
|
||
| # 查找内部的小block (仅考虑尚未被标记为删除的block) |
There was a problem hiding this comment.
[nitpick] The comment is in Chinese. Consider using English comments for better code maintainability and consistency with the rest of the codebase.
| # 查找内部的小block (仅考虑尚未被标记为删除的block) | |
| # Find smaller blocks inside (only consider blocks not yet marked for removal) |
Copilot uses AI. Check for mistakes.
| @@ -279,6 +285,7 @@ def remove_overlaps_low_confidence_blocks(combined_res_list, overlap_threshold=0 | |||
| for j, _, j_block in blocks_inside: | |||
| if j_block not in blocks_to_remove: | |||
| blocks_to_remove.append(j_block) | |||
| marked_indices.add(j) # 标记索引为已处理 | |||
There was a problem hiding this comment.
[nitpick] The comment is in Chinese. Consider using English comments for better code maintainability and consistency with the rest of the codebase.
| marked_indices.add(j) # 标记索引为已处理 | |
| marked_indices.add(j) # Mark the index as processed |
Copilot uses AI. Check for mistakes.
| @@ -298,6 +305,7 @@ def remove_overlaps_low_confidence_blocks(combined_res_list, overlap_threshold=0 | |||
| else: | |||
| # 保留小blocks，删除大block | |||
| blocks_to_remove.append(block) | |||
| marked_indices.add(i) # 标记当前索引为已处理 | |||
There was a problem hiding this comment.
[nitpick] The comment is in Chinese. Consider using English comments for better code maintainability and consistency with the rest of the codebase.
| marked_indices.add(i) # 标记当前索引为已处理 | |
| marked_indices.add(i) # Mark the current index as processed |
Copilot uses AI. Check for mistakes.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: