Upstream cherry pick - spell check and link checking #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve Linting, spelling, links and better control script this includes spellcheck for both other files and markdown updated lint script that has more options - including formatting enabled markdown link checker as the first pass on making sure links work update CI to only activate on changed files
BryanQuigley
force-pushed
the
upstream_cherry_pick
branch
2 times, most recently
from
d6dc0a9 to
53657c5
Compare
BryanQuigley
force-pushed
the
upstream_cherry_pick
branch
from
53657c5 to
b52da19
Compare
Member
Author
|
Fixed the npm build, this is ready for review / discussion. The spell checker can sometimes get annoying with names/organization names, but can be controlled on a per document level: We can see how it goes on the next few reviews? |
lydiascarf
approved these changes
Nov 14, 2025
Collaborator
lydiascarf
left a comment
lydiascarf
left a comment
There was a problem hiding this comment.
looks good! i'm excited about having link checks
Member
Author
|
Ty, merging, let's watch the next few PRs and see if it needs tweaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling two commits from upstream
the bigger issue one is timwis/jkan#292 which we may need to be careful it doesn't break our current flows. It will try to validate all links in a PR - and check spelling too.
Works can be added to cspell.json (there are also ways to just disable it or add works for certain files - https://cspell.org/docs/Configuration/document-settings)
It required the img links to not be root based /img/ -> img/. I'm not sure if that has other implications or not.
It is not currently performant enough to run the linter against our whole project (link checking), Hope to improve that over time.
Happy to wait if any other big updates want to land first - as this could require more work.