This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support ES 7.10.0 #313
Merged
Support ES 7.10.0 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
============================================
+ Coverage 72.14% 72.19% +0.05%
Complexity 1990 1990
============================================
Files 201 201
Lines 9567 9570 +3
Branches 849 850 +1
============================================
+ Hits 6902 6909 +7
+ Misses 2252 2248 -4
Partials 413 413
Flags with carried forward coverage won't be shown. Click here to find out more.
|
weicongs-amazon
requested review from
kaituo,
ylwu-amzn,
ohltyler and
yizheliu-amazon
weicongs-amazon
added
odfe-release
version upgrade
kaituo
reviewed
Nov 18, 2020
src/main/java/com/amazon/opendistroforelasticsearch/ad/cluster/MasterEventListener.java
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/ad/indices/AnomalyDetectionIndices.java
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/ad/model/AnomalyDetector.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/opendistroforelasticsearch/ad/ODFERestTestCase.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/opendistroforelasticsearch/ad/rest/AnomalyDetectorRestApiIT.java
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Nov 18, 2020
release-notes/opendistro-for-elasticsearch-anomaly-detection.release-notes-1.12.0.0.md
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Nov 18, 2020
src/main/java/com/amazon/opendistroforelasticsearch/ad/cluster/MasterEventListener.java
Show resolved
Hide resolved
… note; remove the readable name for AD
|
Have you tried installing the built artifact to ES 7.10 cluster ? I think it should work, but better to test. |
Yes, already tested. it works well |
kaituo
reviewed
Nov 19, 2020
kaituo
approved these changes
Nov 20, 2020
ylwu-amzn
reviewed
Nov 20, 2020
| else | ||
| echo "Security plugin is NOT available" | ||
| ./gradlew :integTestRunner --tests "com.amazon.opendistroforelasticsearch.ad.rest.*IT" --tests "com.amazon.opendistroforelasticsearch.ad.e2e.*IT" -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="docker-cluster" -PnumNodes=2 | ||
| ./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="docker-cluster" |
There was a problem hiding this comment.
ES7.10 doesn't support PnumNodes ? How to test cluster with multiple nodes?
There was a problem hiding this comment.
PnumNodes is used for local test, not for remote cluster.
There was a problem hiding this comment.
We need add new task for local testing with multi nodes
There was a problem hiding this comment.
Actually it never worked. I commented in the issue: #194. Let's use that to track the multi node testing changes
There was a problem hiding this comment.
Got it, let's fix in a separate PR
ylwu-amzn
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Support ES 7.10.0
Testing:
./gradlew build./gradlew integTestand/gradlew build./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="elasticsearch"./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="elasticsearch" -Dhttps=true -Duser=admin -Dpassword=adminBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.