Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Fix invalid group failure bug and baseDn #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix invalid group failure bug and baseDn #8

wants to merge 1 commit into from

Conversation

Liron-Berger
Copy link

Fixed two bugs:

  • dn turned into baseDn - currently wasn't happening - the lookup function received the original dn as baseDn.
  • When an error occurred while going over nested groups in one of the groups - due to LDAP wrong or missing results none of the roles were returned. Caught the exception

@hardik-k-shah
Copy link
Member

hardik-k-shah commented Apr 16, 2019 •
edited
Loading

Thanks for working on fixing these bugs.
We will look into your fix meantime can you please add UTs covering your changes?
Please also update your testing efforts in description with test cases covered by you.

@shadowlord017 shadowlord017 mentioned this pull request Apr 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hardik-k-shah hardik-k-shah Awaiting requested review from hardik-k-shah

@elfisher elfisher Awaiting requested review from elfisher

@prashar prashar Awaiting requested review from prashar

@shivangdoshi07 shivangdoshi07 Awaiting requested review from shivangdoshi07

Assignees

@prashar prashar

@NihalHarish NihalHarish

@shivangdoshi07 shivangdoshi07

@hardik-k-shah hardik-k-shah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Liron-Berger @hardik-k-shah @prashar @NihalHarish @shivangdoshi07