Added Election Term Metric #557
Conversation
This Metric will Publish the Only Election term number
| IP_METRICS, | ||
| THREAD_POOL, | ||
| SHARD_STATS, | ||
| MASTER_PENDING, |
There was a problem hiding this comment.
Maybe we can rename MASTER_PENDING as MASTER_METRICS and then election term can also be MASTER_METRICS ?
There was a problem hiding this comment.
In metricPathmap we are making map of Metric name Metric path. So, it is not possible to make same metric name for 2 different paths.
There was a problem hiding this comment.
Can we group MASTER_PENDING and ELECTION_TERM into one metric MASTER_METRICS?
There was a problem hiding this comment.
As from my understanding we want to publish two different metrics. so it is not possible to use same Metric name for two different metrics. If it is a way to use same metric name then can you give some context
| IP_METRICS, | ||
| THREAD_POOL, | ||
| SHARD_STATS, | ||
| MASTER_PENDING, |
There was a problem hiding this comment.
In metricPathmap we are making map of Metric name Metric path. So, it is not possible to make same metric name for 2 different paths.
| IP_METRICS, | ||
| THREAD_POOL, | ||
| SHARD_STATS, | ||
| MASTER_PENDING, |
There was a problem hiding this comment.
Can we group MASTER_PENDING and ELECTION_TERM into one metric MASTER_METRICS?
| @@ -0,0 +1,26 @@ | |||
| /* | |||
| * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
nit: can we change year to 2021 for all new files which need to make change to license header?
This Metric will Publish the Only Election term number
| ADMISSION_CONTROL_COLLECTOR_ERROR("AdmissionControlCollectorError"), | ||
|
|
||
| MASTER_THROTTLING_COLLECTOR_ERROR("MasterThrottlingMetricsCollector"), | ||
|
|
There was a problem hiding this comment.
Add error for all the collectors to maintain consistency
| @Override | ||
| public String toString() { | ||
| return value; | ||
| return this.value; |
There was a problem hiding this comment.
Don't change code that you don't intend to. It changes the git blame.
4 participants
This Metric will Publish the Only Election term number
Tests:
Docker Container Testing
1. Schema of Election term
2. Entry in Election term table
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.