Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

yujias0706
Copy link
Contributor

@yujias0706 yujias0706 commented Mar 15, 2021

Fixes #:

Description of changes:

TotalError and ReaderRestartProcessing will stop showing in service log entry counter if the value is 0
Add default MethodName CollectStatsMetric when MethodName is not provided

Tests:

Tested on AES domain

------------------------------------------------------------------------
Marketplace=yujias-swift-dev
ClientProgram=356098247920:heat-profile-test-1
Program=PerformanceAnalyzerAgent
ESVersion=7.10
rca-version=0.0.1
MethodName=CollectStatsMetric
StartTime=1615870841.554
EndTime=Mon, 15 Mar 2021 22:01:41 PDT
Time=59967 msecs
Timing=total-time:59967.0/1
Counters=TotalError=24,ReaderRestartProcessing=12,Other=12
EOE
------------------------------------------------------------------------
Marketplace=yujias-swift-dev
ClientProgram=356098247920:heat-profile-test-1
Program=PerformanceAnalyzerAgent
ESVersion=7.10
rca-version=0.0.1
MethodName=CollectStatsMetric
StartTime=1616104904.061
EndTime=Thu, 18 Mar 2021 15:02:44 PDT
Time=59990 msecs
Timing=total-time:59990.0/1
Counters=
EOE
------------------------------------------------------------------------
Marketplace=yujias-swift-dev
ClientProgram=356098247920:heat-profile-test-1
Program=PerformanceAnalyzerAgent
ESVersion=7.10
rca-version=0.0.1
MethodName=ProcessMetrics
StartTime=1616108464.409
EndTime=Thu, 18 Mar 2021 16:01:04 PDT
Time=21 msecs
Timing=total-time:21.0/1
Counters=
EOE

If new tests are added, how long do the new ones take to complete

sruti1312
sruti1312 previously approved these changes Mar 16, 2021
@yujias0706 yujias0706 force-pushed the log branch 2 times, most recently from 71e068e to 557b205 Compare March 18, 2021 23:34
@yujias0706 yujias0706 marked this pull request as ready for review March 19, 2021 04:24
jotok
jotok previously approved these changes Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants