Skip to content

build: Upgrade to Node 20 #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnwesson merged 8 commits into from
Sep 6, 2024
Merged

build: Upgrade to Node 20 #847

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ab6ce86
feat: updated node to v20, update ci workflow
BilalQamar95 Aug 16, 2024
c57960f
feat: added lockfile version check workflow
BilalQamar95 Aug 16, 2024
975778b
refactor: updated package-lock
BilalQamar95 Aug 16, 2024
e0282c6
refactor: updated package-lock
BilalQamar95 Aug 16, 2024
78de708
refactor: updated package-lock
BilalQamar95 Aug 16, 2024
02d34ab
Merge branch 'master' of https://github.com/openedx/credentials-theme…
BilalQamar95 Aug 30, 2024
6c51da5
refactor: updated package-lock along with ci & lockfile version workf…
BilalQamar95 Aug 30, 2024
653c1e1
Merge branch 'master' of https://github.com/openedx/credentials-theme…
BilalQamar95 Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,18 @@ jobs:
matrix:
python-version: ['3.8', '3.12']
django-version: ['4.2']
node: [18]
Copy link
Member

@MaxFrank13 MaxFrank13 Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the issue for updating all MFEs there is an example PR that configures the ci.yml file so that the workflow is run with both Node 18 and Node 20. Is this no longer the recommended pattern?

Copy link
Contributor Author

@BilalQamar95 BilalQamar95 Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have discussed this in FWG and the one you mentioned is the recommended pattern. I'm going to draft this for now and wait for prerequisite PR to get merged

steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
architecture: x64
- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
- uses: actions/setup-node@v2-beta
with:
node-version: ${{ matrix.node }}
node-version: ${{ env.NODE_VER }}

- name: run tests with Django ${{ matrix.django-version }}
run: |
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/lockfileversion-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#check package-lock file version

name: Lockfile Version check

on:
push:
branches:
- master
pull_request:

jobs:
version-check:
uses: openedx/.github/.github/workflows/lockfile-check-v20.yml@master
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
Loading