feat: adds sorting support to enterprise-customer-members endpoint #2311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sorting support to the
enterprise-customer-members
endpoint to allow a user to sort by a member'sjoined_org
date and member'sname
.https://2u-internal.atlassian.net/browse/ENT-9861
Testing instructions:
Manage learners
page: http://localhost:18000/admin/enterprise/enterprisecustomer/7dbf461e-8d3d-4a4a-9b20-9c9121f04806/manage_learnersenterprise-customer-members
endpoint and verify that you can sort the results byjoined_org
andname
via the following parameters:-
sort_by=name
: http://localhost:18000/enterprise/api/v1/enterprise-customer-members/7dbf461e-8d3d-4a4a-9b20-9c9121f04806?sort_by=namesort_by=name&is_reversed=true
sort_by=joined_org
: http://localhost:18000/enterprise/api/v1/enterprise-customer-members/7dbf461e-8d3d-4a4a-9b20-9c9121f04806?sort_by=joined_orgsort_by=joined_org&is_reversed=true
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.