-
Notifications
You must be signed in to change notification settings - Fork 197
fix: latex preview not working #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: latex preview not working #2277
Conversation
Thanks for the pull request, @andrii-hantkovskyi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
dbf174d
to
a4e6995
Compare
@andrii-hantkovskyi we need to have a CLA in place for your contribution. Are you working for a company that has an entity CLA in place? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2277 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 195 195
Lines 21624 21624
Branches 1502 1502
=======================================
Hits 20606 20606
Misses 771 771
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@e0d I'm working for RaccoonGang, waiting for my team to approve. |
Thanks @dyudyunov. @e0d Do you need anything else to be able to update the CLA records on your side? |
Hi @e0d, do you have any updates about @andrii-hantkovskyi's CLA check? CC @openedx/cla-problems |
@openedx/cla-problems Friendly reminder to have a look at this PR and see what's missing to get the CLA check to pass. |
Looks like the CLA check is good now @itsjeyd |
TL;DR - [ This PR fixes the issue with LaTeX preview ]
What changed?
Added
|add:criterion.name
to thepreview_name
attribute in the{% include %}
tag.The order of attributes was slightly adjusted, but no functional impact.
Developer Checklist
Translations and JS/SASS compilednot neededTesting Instructions
[ How should a reviewer test this PR? ]
Preview in LaTeX
Uncaught TypeError: Cannot read properties of undefined (reading 'replace')
error in the dev tools consoleReviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora