Skip to content

fix: latex preview not working #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrii-hantkovskyi
Copy link

TL;DR - [ This PR fixes the issue with LaTeX preview ]

What changed?

  • [ More in-depth breakdown of changes ]
    Added |add:criterion.name to the preview_name attribute in the {% include %} tag.
  • [ Peripheral things that got changed ]
    The order of attributes was slightly adjusted, but no functional impact.
  • [ etc... ]

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

  1. Install the plugin from this branch
  2. Add an ORA problem for any unit using this instruction
  3. Make sure you enabled LaTeX response - specify response, paragraph 5
  4. Go to LMS, then the unit where you added the problem
  5. Write something in the response field using LaTeX syntax
  6. Press Preview in LaTeX
  7. You should see formatted text and no Uncaught TypeError: Cannot read properties of undefined (reading 'replace') error in the dev tools console

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 21, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 21, 2025

Thanks for the pull request, @andrii-hantkovskyi!

This repository is currently maintained by @openedx/2u-aurora.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@andrii-hantkovskyi andrii-hantkovskyi force-pushed the upstream/fix-latex-preview branch from dbf174d to a4e6995 Compare February 21, 2025 15:23
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 21, 2025
@e0d
Copy link

e0d commented Feb 21, 2025

@andrii-hantkovskyi we need to have a CLA in place for your contribution. Are you working for a company that has an entity CLA in place?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (f75139d) to head (a4e6995).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2277   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         195      195           
  Lines       21624    21624           
  Branches     1502     1502           
=======================================
  Hits        20606    20606           
  Misses        771      771           
  Partials      247      247           
Flag Coverage Δ
unittests 95.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrii-hantkovskyi
Copy link
Author

@e0d I'm working for RaccoonGang, waiting for my team to approve.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 27, 2025
@dyudyunov
Copy link
Contributor

Hi @e0d @itsjeyd

I can confirm that Andrii is a member of RaccoonGang

@itsjeyd
Copy link

itsjeyd commented Mar 14, 2025

Thanks @dyudyunov.

@e0d Do you need anything else to be able to update the CLA records on your side?

@itsjeyd
Copy link

itsjeyd commented Apr 1, 2025

Hi @e0d, do you have any updates about @andrii-hantkovskyi's CLA check?

CC @openedx/cla-problems

@itsjeyd
Copy link

itsjeyd commented Apr 24, 2025

@openedx/cla-problems Friendly reminder to have a look at this PR and see what's missing to get the CLA check to pass.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 24, 2025
@feanil
Copy link
Contributor

feanil commented Apr 25, 2025

Looks like the CLA check is good now @itsjeyd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Tests Run or CLA Signed
Development

Successfully merging this pull request may close these issues.

7 participants