feat! Dropping Sass support from builtin LTI block (#35769)

feat!: Dropping Sass support from builtin LTI block Co-authored by @ttqureshi
openedx · Nov 5, 2024 · b7d08fb · b7d08fb
1 parent 368827a
commit b7d08fb
Show file tree

Hide file tree

Showing 4 changed files with 64 additions and 70 deletions.
diff --git a/xmodule/assets/LTIBlockDisplay.scss b/xmodule/assets/LTIBlockDisplay.scss
diff --git a/xmodule/assets/lti/_lti.scss b/xmodule/assets/lti/_lti.scss
diff --git a/xmodule/lti_block.py b/xmodule/lti_block.py
@@ -84,7 +84,7 @@
 )
 from xmodule.lti_2_util import LTI20BlockMixin, LTIError
 from xmodule.raw_block import EmptyDataRawMixin
-from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_sass_to_fragment
+from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_css_to_fragment
 from xmodule.xml_block import XmlMixin
 from xmodule.x_module import (
     ResourceTemplates,
@@ -524,7 +524,7 @@ def student_view(self, _context):
         """
         fragment = Fragment()
         fragment.add_content(self.runtime.service(self, 'mako').render_lms_template('lti.html', self.get_context()))
-        add_sass_to_fragment(fragment, 'LTIBlockDisplay.scss')
+        add_css_to_fragment(fragment, 'LTIBlockDisplay.css')
         add_webpack_js_to_fragment(fragment, 'LTIBlockDisplay')
         shim_xmodule_js(fragment, 'LTI')
         return fragment

diff --git a/xmodule/static/css-builtin-blocks/LTIBlockDisplay.css b/xmodule/static/css-builtin-blocks/LTIBlockDisplay.css
@@ -0,0 +1,62 @@
+@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");
+
+.xmodule_display.xmodule_LTIBlock {
+    /* stylelint-disable-line */
+    /* stylelint-disable-line */
+    /* stylelint-disable-line */
+    /* stylelint-disable-line */
+}
+
+.xmodule_display.xmodule_LTIBlock h2.problem-header {
+    display: inline-block;
+}
+
+.xmodule_display.xmodule_LTIBlock div.problem-progress {
+    display: inline-block;
+    padding-left: calc((var(--baseline)/4));
+    color: #666;
+    font-weight: 100;
+    font-size: 1em;
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti {
+    margin: 0 auto;
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link {
+    font-size: 14px;
+    background-color: var(--sidebar-color);
+    padding: var(--baseline);
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link .lti-link {
+    margin-bottom: 0;
+    text-align: right;
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link .lti-link .link_lti_new_window {
+    font-size: 13px;
+    line-height: 20.72px;
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti form.ltiLaunchForm {
+    display: none;
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti iframe.ltiLaunchFrame {
+    width: 100%;
+    height: 800px;
+    display: block;
+    border: 0px;
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti h4.problem-feedback-label {
+    font-weight: 100;
+    font-size: 1em;
+    font-family: "Source Sans", "Open Sans", Verdana, Geneva, sans-serif, sans-serif;
+}
+
+.xmodule_display.xmodule_LTIBlock div.lti div.problem-feedback {
+    margin-top: calc((var(--baseline)/4));
+    margin-bottom: calc((var(--baseline)/4));
+}