-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: block_structure.storage_backing_for_cache toggle removed depr32 #33108
Conversation
Thanks for the pull request, @Yagnesh1998! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
* feat!: upgrading django-storages to 1.10.1
…penedx#33109) This reverts commit 9281ea4.
…2571)" (openedx#33109)" (openedx#33111) This reverts commit 191b825.
* feat: adding unenrollments to event bus * fix: quality fixes * fix: tweaks to pass tests * fix: more tweaks for testing --------- Co-authored-by: John Nagro <[email protected]>
* feat: upgrading `django-storages` to `1.11.1`
…penedx#32571)" (openedx#33109)" (openedx#33111)" (openedx#33113) This reverts commit 2f8475c.
enterprise version bump Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
…#33143) The .dockerignore file smartly excludes lms/static/css from the Docker build, as most of its contents are generated CSS. However, there is one version-controlled subdirectory of lms/static/css: lms/static/css/vendor. In order to correctly build a Docker image using a bind-mounted edx-platform repository, we need this vendor directory to be included.
297b044
to
6c65821
Compare
@Yagnesh1998 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
As Per this DEPR: openedx/public-engineering#32
Removing: Toggle labeled 'block_structure.storage_backing_for_cache'. The toggle has the following annotation as a description:
When enabled, block structures are stored in a more permanent storage, like a database, which provides an additional backup for cache misses, instead having them regenerated. The regeneration of block structures is a time consuming process. Therefore, enabling this switch is recommended for Production.
Supporting information
as per the original jeera issue https://openedx.atlassian.net/browse/DEPR-145, this toggle is removed