-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable content libraries runtime tests [FC-0062] #35783
base: master
Are you sure you want to change the base?
Re-enable content libraries runtime tests [FC-0062] #35783
Conversation
Thanks for the pull request, @pomegranited! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@@ -169,8 +168,7 @@ def test_xblock_metadata(self): | |||
""" | |||
Test the XBlock metadata API | |||
""" | |||
unit_block_key = library_api.create_library_block(self.library.key, "unit", "metadata-u1").usage_key | |||
problem_key = library_api.create_library_block_child(unit_block_key, "problem", "metadata-p1").usage_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: There's no create_library_block_child
method in the api anymore -- and LearningCoreXBlockRuntime doesn't support child blocks, so I've removed parent-child relationships from these tests.
Description
Somewhere in the series of refactorings that this app has undergone, it seems that we removed TestCase from the inheritance tree of the tests in
openedx/core/djangoapps/content_libraries/tests/test_runtime.py
, effectively skipping the test cases.This PR re-enables the tests and fixes what's broken since they were disabled.
Supporting information
Builds on/replaces: #35531
Private-ref: FAL-3927
Testing instructions
Check the logs of
openedx-1-with-lms
andopenedx-2-with-cms
to confirm that tests are run foropenedx/core/djangoapps/content_libraries/tests/test_runtime.py
. Some will be skipped for the lms, some skipped for the cms, but all tests should be run by one or the other.Deadline
ASAP -- want to get into Sumac