-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing some code #35952
base: master
Are you sure you want to change the base?
testing some code #35952
Conversation
…nedx#35911) Co-authored-by: bszabo <[email protected]>
openedx#35915) This reverts commit 1535ff7 to see if it might have caused ICM-119 (missing text.replace)
* chore(deps): update jest monorepo to v29 * chore: updated failing snapshot --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Bilal Qamar <[email protected]>
* feat!: upgrading api to DRF.
The Studio Maintenance app had two features: * "Force Course Publish", which literally doesn't do anything. All it does is tell you what version *would* be seen by users *if* the course were to be published--no publishing actually occurs via this feature. * "Announcements", which writes to the announcements_announcement database table, but doesn't actually display anywhere. Having these pages in the platform is actively misleading and creates a maintenance burden for edx-platform developers, so we remove them. Note that this commit does not include a migration for the announcements Django app. So, announcements_announcement table will not be deleted. Given the small expected size of any past-authored announcements, we are not worried about leaving them in the database perpetually.
…#35930) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat!: upgrading api to DRF.
…35599) * feat!: upgrading api to DRF.
…35549) chore: Add Django settings flags to roll out the extracted XBlocks
Thanks for the pull request, @salman2013! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.