-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support design tokens and paragon 23 #1198
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4aa89ce
to
f081d9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
+ Coverage 58.53% 58.57% +0.03%
==========================================
Files 117 117
Lines 2320 2322 +2
Branches 639 643 +4
==========================================
+ Hits 1358 1360 +2
Misses 901 901
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -23,7 +23,7 @@ describe('MockedPluginSlot', () => { | |||
expect(component).toBeInTheDocument(); | |||
|
|||
// Direct children | |||
const quote = component.querySelector(':scope > q'); | |||
const quote = component.querySelector(':scope q'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure why used to work (or why after updating paragon is not working) but q is not direct children or article because is wrapped in a div, here the render:
<body>
<div>
<div
role="article"
>
<div>
PluginSlot_
<div>
<q
role="note"
>
How much wood could a woodchuck chuck if a woodchuck could chuck wood?
</q>
</div>
</div>
</div>
</div>
</body>
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, based on the name of the test
renders as the slot children directly if there is content within
it seems like the test should be failing from a "it's not directly rendering the children, it's wrapping them in a couple layers of divs" perspective on latest master
too. I double checked and got the same render output on latest master.
MockedPluginSlot
is absolutely not behaving in the way that
renders as the slot children directly if there is content within
expects.
Since this is only testing a mock component, I think the best path forward here is to make an issue documenting the discrepancy and use your minimal change to get tests passing again as-is for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created the corresponding issue in the MFE repo
Sandbox deployment successful 🚀 |
Sandbox deployment failed 💥 |
3b99208
to
54693d0
Compare
Sandbox deployment successful 🚀 |
54693d0
to
54c1d2b
Compare
Sandbox deployment successful 🚀 |
Warning
This PR should not be merge to
master
directly, it should point tomaster-design-tokens
once the branch has been created.Description
This PR updates frontend app account to support CSS variables and the corresponding paragon design tokens.
Changes implemented:
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first: