Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support design tokens and paragon 23 #1198

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Feb 27, 2025

Warning

This PR should not be merge to master directly, it should point to master-design-tokens once the branch has been created.

Description

This PR updates frontend app account to support CSS variables and the corresponding paragon design tokens.

Changes implemented:

  • Replace Paragon SCSS variables with CSS variables.
  • Replace deprecated components Input, ValidationFormGroup

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 27, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 27, 2025

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 27, 2025
@dcoa dcoa changed the title feat: support design tokens and paragon 23 [WIP] feat: support design tokens and paragon 23 Feb 27, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Product Review in Contributions Mar 3, 2025
@mphilbrick211 mphilbrick211 moved this from Product Review to Waiting on Author in Contributions Mar 3, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch 4 times, most recently from 4aa89ce to f081d9d Compare March 18, 2025 07:00
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (17e12f7) to head (54693d0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
+ Coverage   58.53%   58.57%   +0.03%     
==========================================
  Files         117      117              
  Lines        2320     2322       +2     
  Branches      639      643       +4     
==========================================
+ Hits         1358     1360       +2     
  Misses        901      901              
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -23,7 +23,7 @@ describe('MockedPluginSlot', () => {
expect(component).toBeInTheDocument();

// Direct children
const quote = component.querySelector(':scope > q');
const quote = component.querySelector(':scope q');
Copy link
Contributor Author

@dcoa dcoa Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure why used to work (or why after updating paragon is not working) but q is not direct children or article because is wrapped in a div, here the render:


    <body>
      <div>
        <div
          role="article"
        >
          <div>
            PluginSlot_
            <div>
              <q
                role="note"
              >
                How much wood could a woodchuck chuck if a woodchuck could chuck wood?
              </q>
            </div>
          </div>
        </div>
      </div>
    </body>
```

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, based on the name of the test

renders as the slot children directly if there is content within

it seems like the test should be failing from a "it's not directly rendering the children, it's wrapping them in a couple layers of divs" perspective on latest master too. I double checked and got the same render output on latest master.

MockedPluginSlot is absolutely not behaving in the way that

renders as the slot children directly if there is content within

expects.

Since this is only testing a mock component, I think the best path forward here is to make an issue documenting the discrepancy and use your minimal change to get tests passing again as-is for this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the corresponding issue in the MFE repo

@dcoa dcoa added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 18, 2025
@dcoa dcoa requested a review from brian-smith-tcril March 18, 2025 21:50
@dcoa dcoa marked this pull request as ready for review March 18, 2025 22:12
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 3b99208 to 54693d0 Compare March 25, 2025 23:19
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 54693d0 to 54c1d2b Compare March 31, 2025 20:43
@dcoa dcoa changed the title [WIP] feat: support design tokens and paragon 23 feat: support design tokens and paragon 23 Mar 31, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants