Skip to content

feat: adds dimiss confirmation modal #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jun 12, 2025

https://2u-internal.atlassian.net/browse/ENT-10142

Adds the dismiss confirmation modal.

Screen.Recording.2025-06-12.at.3.38.01.PM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messaged offline, but need to add changes to the dismiss method that calls the LmsApiService before merge here

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (77d2536) to head (5157007).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/components/FloatingCollapsible/index.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
- Coverage   87.50%   86.39%   -1.11%     
==========================================
  Files         741      742       +1     
  Lines       16744    16805      +61     
  Branches     3445     3450       +5     
==========================================
- Hits        14651    14519     -132     
- Misses       2027     2220     +193     
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@katrinan029 katrinan029 requested a review from kiram15 June 19, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants