feat: add and integrated decline modal for BNR requests #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1556 +/- ##
==========================================
- Coverage 87.50% 86.37% -1.13%
==========================================
Files 741 741
Lines 16744 16777 +33
Branches 3445 3517 +72
==========================================
- Hits 14651 14491 -160
- Misses 2027 2211 +184
- Partials 66 75 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10355
branch
from
86c3316 to
968b2fc
Compare
Comment on lines
+87
to
+88
| Declining an enrollment request cannot be undone. If you change your mind, the learner will have to | ||
| submit a new enrollment request. |
There was a problem hiding this comment.
I think this text is a bit mislead as admins would still have the option to cancel an approved request. Can we get more clarity on this from Product/UX?
There was a problem hiding this comment.
I just implemented this as per Figma. We can ask Sikhu about that.
There was a problem hiding this comment.
We can also ask from sikhu before final testing, it will be a simple change at that time, if required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA- ENT10355
Screen.Recording.2025-06-19.at.2.31.17.PM.mov
For all changes
Only if submitting a visual change