feat: Add Invite Admins table with header and kebab menu actions #1744
Conversation
chore: Add CODEOWNERS file to request review from all enterprise teams
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1744 +/- ##
==========================================
- Coverage 87.12% 87.11% -0.01%
==========================================
Files 781 785 +4
Lines 17886 17947 +61
Branches 3748 3757 +9
==========================================
+ Hits 15583 15635 +52
- Misses 2228 2236 +8
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pbitla-sonata
force-pushed
the
pbitla/ENT-11262
branch
from
eff5c0b to
cd08691
Compare
hkumar1-sonata
left a comment
hkumar1-sonata
left a comment
There was a problem hiding this comment.
Changes Looks Good to me Just added some small suggestions / questions to address.
| {joinedOrg} | ||
| </Col> | ||
| <Col> | ||
| <h5 className="pt-2 text-uppercase">Role</h5> |
There was a problem hiding this comment.
can we use ii18 for Role?
| </Row> | ||
| </Col> | ||
| <Col> | ||
| <h5 className="pt-2 text-uppercase">Joined org</h5> |
There was a problem hiding this comment.
can we use ii18 for Joined Org?
| const data = camelCaseObject(response.data); | ||
| setEnterpriseAdminsTableData({ | ||
| itemCount: data.count, | ||
| pageCount: data.numPages ?? Math.floor(data.count / options.pageSize), |
There was a problem hiding this comment.
Using Math.floor can undercount pages when the total isn’t a multiple of pageSize, making the last page unreachable.
Suggestion: use Math.ceil(data.count / args.pageSize) to correctly include partial pages and avoid missing records.
3 participants
attached screenshot: