feat: add Learners tab and gate it behind feature flag #1745
+183
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hkumar1-sonata
left a comment
hkumar1-sonata
left a comment
There was a problem hiding this comment.
Code changes Looks good to me. Just have a question/concern please address
| const mapStateToProps = (state) => ({ | ||
| enterpriseId: state.portalConfiguration.enterpriseId, | ||
| // learnersTabEnabled: state.portalConfiguration.enterpriseFeatures?.enterprise_invite_admins_enabled, | ||
| learnersTabEnabled: true, |
Contributor
There was a problem hiding this comment.
Why is learnersTabEnabled hardcoded to true here? This bypasses the actual feature flag. Should we instead read it from enterpriseFeatures?.enterprise_invite_admins_enabled to reflect real usage?
There was a problem hiding this comment.
This was temporarily set to true for local testing. I’ll update it to read from the actual feature flag(.enterpriseFeatures?.enterprise_invite_admins_enabled)
ssrijaindukuri-sonata
force-pushed
the
srija/ENT-11231
branch
3 times, most recently
from
a46e553 to
a293abd
Compare
ssrijaindukuri-sonata
force-pushed
the
srija/ENT-11231
branch
from
a293abd to
cd360a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/ENT-11231
Changes: