Skip to content

fix: fixed cohesion page url setup #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

fix: fixed cohesion page url setup #1476

merged 1 commit into from
Apr 23, 2025

Conversation

ayesha-waris
Copy link

INF-1858

Description
A solution for the Cohesion tracking issue on the login/register page.
The problem occurs because Cohesion's pageUrl is set only on the initial page load (/login or /register) and does not automatically update when users switch tabs due to client-side routing (no browser pageView event).

To fix this, a manual pageView event needs to be triggered on the click handler for the 'Register' and 'Sign In' tabs. This forces Cohesion to update its context.

@ayesha-waris ayesha-waris requested a review from a team as a code owner April 23, 2025 09:39
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (a53334d) to head (8af8fde).
Report is 3 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/common-components/RouteTracker.jsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1476      +/-   ##
===========================================
- Coverage    86.07%   85.94%   -0.14%     
===========================================
  Files          139      140       +1     
  Lines         2471     2476       +5     
  Branches       678      677       -1     
===========================================
+ Hits          2127     2128       +1     
- Misses         328      332       +4     
  Partials        16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ayesha-waris ayesha-waris merged commit f3f14fb into 2u-main Apr 23, 2025
4 of 6 checks passed
@ayesha-waris ayesha-waris deleted the Ayesha/INF-1858-b branch April 23, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants