feat: Add AdvancedEditors with an iframe [FC-0076]#1568
feat: Add AdvancedEditors with an iframe [FC-0076]#1568ChrisChV merged 8 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by @openedx/2u-tnl. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
+ Coverage 92.94% 93.08% +0.13%
==========================================
Files 1073 1093 +20
Lines 21098 21643 +545
Branches 4479 4582 +103
==========================================
+ Hits 19610 20146 +536
- Misses 1422 1431 +9
Partials 66 66 ☔ View full report in Codecov by Sentry. |
c547d84 to
c0f84ab
Compare
DanielVZ96
left a comment
There was a problem hiding this comment.
👍
- I tested this: Ran the testing instructions
- I read through the code
- I checked for accessibility issues
- Includes documentation
|
When I edit a drag and drop, it doesn't refresh in the preview until I refresh the page. And the card in the search results never updated at all. Is this just a proof of concept or do you want to merge this now? If so, we need to fix that first. |
@bradenmacdonald Fixed with the new changes in openedx/openedx-platform#36029
I prefer to merge it now to have a good base to work on and fix bugs specific to each block. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
I tested this and reviewed the code and it's working well. The only minor issue I found is that the Google Document XBlock editor modal does not close when I press Save (though it does save).
…x#1568) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Description
Creates the
AdvancedEditorto support editors like Drag and Drop, openresponse, poll, survey, and other advanced editors.Follow this discovery for next steps.
AdvancedEditorcreated to callstudio_viewof the blockLibraryBlockto support any view (and usestudio_viewinAdvancedEditor)xblock-eventmessage to close the Advanced editor on cancel or saveUseful information to include:
Supporting information
Testing instructions
LIBRARY_SUPPORTED_BLOCKS="problem,video,html,poll,drag-and-drop-v2,lti_consumer,google-document,survey"in.env.developmentAdvanced module listadd:Other information
N/A