refactor: Build new action buttons for cancel confirmation modal [FC-0076]

[ChrisChV]

Description

• Build new action buttons for cancel confirmation modal in basic block and advanced block editors.
• Which edX user roles will this change impact? "Course Author"

Supporting information

• GitHub issue: [Library Editors] Add cancel confirmation popup to Advanced editors #1669 (comment)
• Internal ticket: FAL-4091

Testing instructions

• Go to the library home of a library
• Create a new text component.
• Open the text component editor, make a change, and click cancel. Verify the new Modal.
• Create a new drag and drop.
• Open the drag and drop editor, click cancel. Verify the new Modal.

Other information

N/A

[openedx-webhooks]

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (341a03c) to head (3ab35c7).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1732   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files        1132     1132           
  Lines       23043    23047    +4     
  Branches     4864     4867    +3     
=======================================
+ Hits        21553    21557    +4     
  Misses       1422     1422           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[navinkarkera]

@ChrisChV Looks good. Left some suggestions to simplify css.

• I tested this: Followed test instructions
• I read through the code
• I checked for accessibility issues
• Includes documentation

[navinkarkera]

Suggested change

	<div className="w-100 d-flex justify-content-between">
	<Button
	variant="outline-brand"
	onClick={() => onCloseEditor?.()}
	>
	<FormattedMessage {...messages.discardChangesButtonlabel} />
	</Button>
	<Button
	variant="primary"
	onClick={closeCancelConfirmModal}
	>
	<FormattedMessage {...messages.keepEditingButtonLabel} />
	</Button>
	</div>
	<>
	<Button
	variant="outline-brand"
	onClick={() => onCloseEditor?.()}
	>
	<FormattedMessage {...messages.discardChangesButtonlabel} />
	</Button>
	<ActionRow.Spacer />
	<Button
	variant="primary"
	onClick={closeCancelConfirmModal}
	>
	<FormattedMessage {...messages.keepEditingButtonLabel} />
	</Button>
	</>

If we apply the previous change, this can be simplified with just a spacer in between.

Make sure to import ActionRow

[ChrisChV]

Updated: https://github.com/openedx/frontend-app-authoring/pull/1732/files#diff-5e596e3f2bd4c8fc64c20b36264a9407df504b5cd2114991d73d5a802411593eR21
I used the footerAction instead, so this code is refactored

[navinkarkera]

Looks much better 👍

[bradenmacdonald]

Changes look fine to me. I didn't test it. Can we get the coverage test passing?