Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Dec 23, 2025

Description

This PR updates the text on the import summary shown on partial imports.

image

This also fixes a crash that occurred when the list of courses was returned with an empty imported library list.

Useful information to include:

  • Which user roles will this change impact?
    "Course Author",

Supporting information

Testing instructions

You need a successful partial course import to a library where not all blocks are supported (i. e., a course with a "Randomized Content Block").
If you do not have one, do the following:

  • Create a new course
  • Add a "Randomized Content Block"
  • Create a new library
  • Go to Tools > Import
  • Click on + Import Course and import the course with the "Randomized Content Block" to the library.

If you have a library with a successful partial course import, do the following:

  • Open the library with the import
  • Go to Tools > Import
  • Find the import and click on the right arrow (>) on the import card
  • Check if the text was updated in the Import Summary

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Private ref: FAL-4308

@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 23, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 23, 2025
Comment on lines +43 to +45
if (libraries.length !== 0) {
result[libraries[0].sourceKey] = libraries.map(item => item.targetKey);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was crashing for me because the backend was returning some courses with an empty library list.

I didn't dig into whether it was an intended change on the backend, since I think this check won't cause any harm here.

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.92%. Comparing base (f4d20eb) to head (1eddb50).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2772   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files        1240     1242    +2     
  Lines       28528    28557   +29     
  Branches     6514     6496   -18     
=======================================
+ Hits        27081    27109   +28     
- Misses       1376     1377    +1     
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido requested a review from navinkarkera December 23, 2025 14:18
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 23, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Dec 23, 2025
Co-authored-by: Navin Karkera <[email protected]>
@rpenido rpenido requested a review from ChrisChV December 24, 2025 13:19
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChrisChV ChrisChV merged commit 7f10575 into openedx:master Dec 24, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants