-
Notifications
You must be signed in to change notification settings - Fork 178
fix: import summary text #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import summary text #2772
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| if (libraries.length !== 0) { | ||
| result[libraries[0].sourceKey] = libraries.map(item => item.targetKey); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was crashing for me because the backend was returning some courses with an empty library list.
I didn't dig into whether it was an intended change on the backend, since I think this check won't cause any harm here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2772 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 1240 1242 +2
Lines 28528 28557 +29
Branches 6514 6496 -18
=======================================
+ Hits 27081 27109 +28
- Misses 1376 1377 +1
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Navin Karkera <[email protected]>
ChrisChV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
This PR updates the text on the import summary shown on partial imports.
This also fixes a crash that occurred when the list of courses was returned with an empty imported library list.
Useful information to include:
"Course Author",
Supporting information
Testing instructions
You need a successful partial course import to a library where not all blocks are supported (i. e., a course with a "Randomized Content Block").
If you do not have one, do the following:
Tools > Import+ Import Courseand import the course with the "Randomized Content Block" to the library.If you have a library with a successful partial course import, do the following:
Tools > Import>) on the import cardImport SummaryBest Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'Private ref: FAL-4308