feat: course import filter in library and fix list order #2773

navinkarkera · 2025-12-24T04:44:54Z

Description

Adds filter to show/hide previously imported courses in course import page in libraries.
Fix issue with ordering of courses listing.

Useful information to include:

Which user roles will this change impact? "Course Author"

Supporting information

Import from Course stepper UI #2524 (comment)
Depends on: feat: allow specifying custom page size for course list api edx-platform#37815
Private-ref: https://tasks.opencraft.com/browse/FAL-4308

Testing instructions

Check that filter mentioned in Import from Course stepper UI #2524 (comment) works as expected.
Verify that the course listing order is consistent.

Other information

Include anything else that will help reviewers and consumers understand the change.

Does this change depend on other changes elsewhere?
Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

Any new files are using TypeScript (.ts, .tsx).
Avoid propTypes and defaultProps in any new or modified code.
Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
All new i18n messages in messages.ts files have a description for translators to use.
Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

openedx-webhooks · 2025-12-24T04:45:00Z

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-12-24T06:07:31Z

Codecov Report

❌ Patch coverage is 96.22642% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.95%. Comparing base (7f10575) to head (44c4d28).

Files with missing lines	Patch %	Lines
src/studio-home/hooks.tsx	50.00%	2 Missing ⚠️
src/studio-home/tabs-section/courses-tab/index.tsx	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2773      +/-   ##
==========================================
+ Coverage   94.92%   94.95%   +0.02%     
==========================================
  Files        1242     1245       +3     
  Lines       28557    28639      +82     
  Branches     6300     6511     +211     
==========================================
+ Hits        27109    27195      +86     
+ Misses       1390     1386       -4     
  Partials       58       58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rpenido

LGTM 👍
Thank you for your work, @navinkarkera!

I tested this using the instructions from the PR
I read through the code
I checked for accessibility issues
Includes documentation

One small issue that I found is that, since we are filtering in the frontend, the count will act differently from the other filters:

Since we don't paginate here (right?), maybe an easy solution will be hide the count altogether on this page.

rpenido · 2025-12-24T13:44:52Z

...udio-home/tabs-section/courses-tab/courses-filters/courses-imported-filter-modal/context.tsx

+      for (const libraries of Object.values(migrationInfoData)) {
+        // The map key in `migrationInfoData` is in camelCase.
+        // In the processed map, we use the key in its original form.
+        result[libraries[0]?.sourceKey] = libraries.map(item => item.targetKey);


nit: to prevent a result["undefined"] = [] item

Suggested change

result[libraries[0]?.sourceKey] = libraries.map(item => item.targetKey);

if (libraries.length !== 0) {

result[libraries[0].sourceKey] = libraries.map(item => item.targetKey);

}

ChrisChV

Looks good! Fix the nits to merge it 👍

…rary

navinkarkera · 2025-12-25T05:45:04Z

Since we don't paginate here (right?), maybe an easy solution will be hide the count altogether on this page

@rpenido We try not to paginate by using a very large page_size but still pagination is there. And the number shows that some courses are not visible.

navinkarkera · 2025-12-26T05:56:02Z

@ChrisChV This is ready to be merged

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Dec 24, 2025

openedx-webhooks added this to Contributions Dec 24, 2025

github-project-automation bot moved this to Needs Triage in Contributions Dec 24, 2025

navinkarkera mentioned this pull request Dec 24, 2025

feat: allow specifying custom page size for course list api openedx/edx-platform#37815

Merged

navinkarkera marked this pull request as ready for review December 24, 2025 05:44

navinkarkera mentioned this pull request Dec 24, 2025

refactor: course import analysis and details page in libraries #2774

Merged

7 tasks

rpenido approved these changes Dec 24, 2025

View reviewed changes

ChrisChV approved these changes Dec 24, 2025

View reviewed changes

navinkarkera added 11 commits December 25, 2025 11:11

refactor: convert to typescript

1a4e2f6

feat: show hide already imported courses in course import page in lib…

4706e91

…rary

chore: remove comments and update imports

3e8b897

refactor: initial load of courses in import page

6df8f01

fix: incorrect course list order loading

18ebc39

chore: fix lint issues

e32b2f0

test: add tests

d0c91c6

test: fix failing test

3741d43

fix: coverage issue

733eecd

fixup! fix: coverage issue

4c9e720

fix: avoid undefined in object

44c4d28

navinkarkera force-pushed the navin/fal-4308/course-import-filter branch from 0f3fdc1 to 44c4d28 Compare December 25, 2025 05:44

navinkarkera requested review from ChrisChV and rpenido December 25, 2025 05:46

ChrisChV merged commit 0f20267 into openedx:master Dec 29, 2025
7 checks passed

github-project-automation bot moved this from Needs Triage to Done in Contributions Dec 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: course import filter in library and fix list order #2773

feat: course import filter in library and fix list order #2773

Uh oh!

navinkarkera commented Dec 24, 2025 •

edited

Loading

Uh oh!

openedx-webhooks commented Dec 24, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 24, 2025 •

edited

Loading

Uh oh!

rpenido left a comment

Uh oh!

rpenido Dec 24, 2025

Uh oh!

navinkarkera Dec 25, 2025

Uh oh!

ChrisChV left a comment

Uh oh!

navinkarkera commented Dec 25, 2025

Uh oh!

navinkarkera commented Dec 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-        result[libraries[0]?.sourceKey] = libraries.map(item => item.targetKey);
+        if (libraries.length !== 0) {
+          result[libraries[0].sourceKey] = libraries.map(item => item.targetKey);
+        }

feat: course import filter in library and fix list order #2773

feat: course import filter in library and fix list order #2773

Uh oh!

Conversation

navinkarkera commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Other information

Best Practices Checklist

Uh oh!

openedx-webhooks commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rpenido left a comment

Choose a reason for hiding this comment

Uh oh!

rpenido Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

navinkarkera Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisChV left a comment

Choose a reason for hiding this comment

Uh oh!

navinkarkera commented Dec 25, 2025

Uh oh!

navinkarkera commented Dec 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

navinkarkera commented Dec 24, 2025 •

edited

Loading

openedx-webhooks commented Dec 24, 2025 •

edited

Loading

codecov bot commented Dec 24, 2025 •

edited

Loading