Skip to content

Conversation

@irtazaakram
Copy link
Member

Description

This pull request does two things:

  1. Deprecates the ENABLE_GRADING_METHOD_IN_PROBLEMS toggle
  2. Adds the missing Grading Method view

Background / Rationale:

Impact on user roles:

  • Course Authors / Studio users: Will now see the grading method displayed in problem block settings and can change it.
  • Developers: Removes reliance on the deprecated feature toggle.

UI Changes:

Before:
Screenshot 2026-01-07 at 2 59 41 PM

After:
Screenshot 2026-01-07 at 3 00 36 PM

Supporting information

Testing instructions

openedx-unsupported/frontend-lib-content-components#430 (comment)
openedx-unsupported/frontend-lib-content-components#430 (comment)

Other information

openedx/edx-platform#37811

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@irtazaakram irtazaakram moved this to 👀 In review in Aximprovements Team Jan 7, 2026
@irtazaakram irtazaakram moved this from 👀 In review to 🏗 In progress in Aximprovements Team Jan 7, 2026
@irtazaakram irtazaakram self-assigned this Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (2209242) to head (8605435).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2795   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files        1256     1256           
  Lines       28800    28814   +14     
  Branches     6538     6541    +3     
=======================================
+ Hits        27358    27372   +14     
+ Misses       1384     1371   -13     
- Partials       58       71   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

1 participant