Skip to content

fix: Bug when adding spaces to containers names in course outline#2825

Merged
ChrisChV merged 1 commit intoopenedx:masterfrom
open-craft:chris/fix-broken-space-in-names
Jan 15, 2026
Merged

fix: Bug when adding spaces to containers names in course outline#2825
ChrisChV merged 1 commit intoopenedx:masterfrom
open-craft:chris/fix-broken-space-in-names

Conversation

@ChrisChV
Copy link
Contributor

Description

Supporting information

Testing instructions

  • Go to the course outline of a course.
  • Add a section, subsection, or unit.
  • Rename the title of the container and verify that you can add spaces.
  • Also verify that you can select containers using the keyboard.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 14, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV
Copy link
Contributor Author

@bradenmacdonald Could you review this small PR?

@bradenmacdonald
Copy link
Contributor

@ChrisChV There is still an issue... now when I try to select a unit using the keyboard, the space key scrolls the page. We need to capture the event AND prevent default, but only if the text box is not handling the event. The textbox should be capturing the event somehow and stopping it from bubbling up to the container DIV ?

Here I am pressing shift-tab a few times, then space:

Screen.Recording.2026-01-14.at.10.48.23.AM.mov

@ChrisChV
Copy link
Contributor Author

@bradenmacdonald Sorry for not seeing that issue. Fixed: cf31277

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and fixes the bug. Thanks!

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.07%. Comparing base (969f7a2) to head (a7de39e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2825      +/-   ##
==========================================
+ Coverage   95.04%   95.07%   +0.02%     
==========================================
  Files        1265     1266       +1     
  Lines       29128    29248     +120     
  Branches     6630     6671      +41     
==========================================
+ Hits        27686    27807     +121     
+ Misses       1384     1371      -13     
- Partials       58       70      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV force-pushed the chris/fix-broken-space-in-names branch 2 times, most recently from 77bb71e to bc959e8 Compare January 15, 2026 12:52
- Fixes the bug introduced in openedx#2732
- Removes the unnecessary `preventDefault`
@ChrisChV ChrisChV force-pushed the chris/fix-broken-space-in-names branch from bc959e8 to a7de39e Compare January 15, 2026 13:33
@ChrisChV ChrisChV merged commit 3076dc7 into openedx:master Jan 15, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

Comments