fix: Bug when adding spaces to containers names in course outline#2825
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@bradenmacdonald Could you review this small PR? |
|
@ChrisChV There is still an issue... now when I try to select a unit using the keyboard, the space key scrolls the page. We need to capture the event AND prevent default, but only if the text box is not handling the event. The textbox should be capturing the event somehow and stopping it from bubbling up to the container DIV ? Here I am pressing Screen.Recording.2026-01-14.at.10.48.23.AM.mov |
|
@bradenmacdonald Sorry for not seeing that issue. Fixed: cf31277 |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Looks great and fixes the bug. Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2825 +/- ##
==========================================
+ Coverage 95.04% 95.07% +0.02%
==========================================
Files 1265 1266 +1
Lines 29128 29248 +120
Branches 6630 6671 +41
==========================================
+ Hits 27686 27807 +121
+ Misses 1384 1371 -13
- Partials 58 70 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
77bb71e to
bc959e8
Compare
- Fixes the bug introduced in openedx#2732 - Removes the unnecessary `preventDefault`
bc959e8 to
a7de39e
Compare
Description
preventDefaultSupporting information
Testing instructions
Other information
N/A
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'