Skip to content

chore: Remove feature flag for secured algolia api key #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

brobro10000
Copy link
Member

Removing feature flag related to the secured_algolia_api_key which validated if the enterprise customer had the catalogQuerySearchFiltersEnabled enabled. The feature is currently enabled for all customers deprecating the usage of the waffle flag itself.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (bc0ecec) to head (952e7cf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
- Coverage   90.35%   90.34%   -0.02%     
==========================================
  Files         419      419              
  Lines        9475     9462      -13     
  Branches     2275     2206      -69     
==========================================
- Hits         8561     8548      -13     
  Misses        880      880              
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brobro10000 brobro10000 merged commit eec712a into master Jul 10, 2025
9 checks passed
@brobro10000 brobro10000 deleted the hu/ent-10317 branch July 10, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants