Skip to content

feat: Resize textarea using alt+up and alt+down arrow keys #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arbirali
Copy link

πŸ“ Description

This PR introduces a keyboard accessibility enhancement to the textarea component, allowing users to resize it vertically using the keyboard. Specifically:

  • Pressing Alt + ↑ (Up Arrow) decreases the height of the textarea.
  • Pressing Alt + ↓ (Down Arrow) increases the height of the textarea.

This improvement supports keyboard-only users and enhances overall usability.

Related issue: tutor-indigo/#146
Taiga Task (if accessible): US 75 – Keyboard accessible textarea resizing
Live Preview: Profile Page – Sandbox


πŸ§ͺ How Has This Been Tested?

  • Manually tested across Chrome, Firefox, and Safari.
  • Verified that the height increases/decreases correctly with the specified key combinations.
  • Confirmed that default textarea behavior and form submission remain intact.

πŸ–ΌοΈ Screenshots/Sandbox (optional):

image

Before After
Textarea not resizable via keyboard Textarea resizable using Alt + ↑ / ↓

βœ… Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

πŸ“¦ Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-infinity to do it.
  • πŸŽ‰ πŸ™Œ Celebrate! Thanks for your contribution.

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 65.97%. Comparing base (3601cb6) to head (9cd0b4f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/profile/forms/Bio.jsx 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
- Coverage   66.82%   65.97%   -0.85%     
==========================================
  Files          51       51              
  Lines         856      870      +14     
  Branches      177      183       +6     
==========================================
+ Hits          572      574       +2     
- Misses        273      285      +12     
  Partials       11       11              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants