-
Notifications
You must be signed in to change notification settings - Fork 118
feat: made profile editable #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @eemaanamir! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2u-main #1212 +/- ##
===========================================
+ Coverage 68.73% 69.54% +0.80%
===========================================
Files 72 92 +20
Lines 1222 1658 +436
Branches 273 401 +128
===========================================
+ Hits 840 1153 +313
- Misses 365 483 +118
- Partials 17 22 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ticket: INF-1890
Summary:
Restored and enhanced the profile editing functionality in the Profile MFE, making it accessible to all users and aligned with the new Figma design.
Key Changes:
Editing Enabled for All Users
Removed the date of birth restriction on profile editing.
UI Updates
Implemented design changes based on the latest Figma specs.
Editable Fields Now Include:
New Feature Toggle:
DISABLE_VISIBILITY_EDITING
environment variable.true
, the visibility toggle in the UI is hidden.