-
Notifications
You must be signed in to change notification settings - Fork 149
feat: use PluginSlot to add your site logo to studio footer #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use PluginSlot to add your site logo to studio footer #520
Conversation
8320ecd to
83e0ab3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 91.22% 91.52% +0.29%
==========================================
Files 5 6 +1
Lines 57 59 +2
Branches 19 19
==========================================
+ Hits 52 54 +2
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current strategy for making the frontend more customizable is by using frontend-plugin-framework PluginSlots as opposed to adding new configuration variables (see https://discuss.openedx.org/t/plugin-slots-vs-configuration/13009)
As of openedx/frontend-app-authoring#1729, it is possible for site operators to replace the entire StudioFooter by utilizing the StudioFooterSlot - if that satisfies your use case then this PR can just be closed.
If you'd like a more granular approach (just replacing the "Powered by Open edX" logo/link), then updating this PR to wrap it in a new PluginSlot is another option.
83e0ab3 to
9186c72
Compare
92910c3 to
01f1605
Compare
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this to use a PluginSlot!
I left a comment about following the pattern we use in other places for plugin slots, if you could update this to do that it would be wonderful.
Thanks!
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for being so patient with my reviews!
I left a couple more comments with some change requests, but this is looking super close to ready to go!
5229274 to
cb64ed4
Compare
cb64ed4 to
2d53df1
Compare
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nearly perfect now!
Just one small naming thing and this will be ready to land!
2d53df1 to
4e6da2e
Compare
use PluginSlot for customizing studio footer logo and it's redirect
move @openedx/frontend-plugin-framework from devDependencies to dependencies in package.json. This fixes this: https://github.com/openedx/frontend-component-footer/actions/runs/14465403436/job/40566531587?pr=520
add instructions for the new pluginslot studio_footer_logo_slot.
4e6da2e to
2c8cf2d
Compare
use PluginSlot to add your site logo to studio footer.