-
Notifications
You must be signed in to change notification settings - Fork 73
feat(i18n): add language preference management functionality #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(i18n): add language preference management functionality #786
Conversation
Thanks for the pull request, @Ang-m4! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
c87194b
to
a17955e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea to have this logic be centralized in frontend-platform, instead of implemented as part of language selection dropdowns. I imagine openedx/frontend-component-footer#493 will have to be refactored accordingly, correct?
I have a minor suggested change, but I'm also not approving yet as I'd like to see PRs that use this.
I was thinking about the list of supported languages to display I'm thinking as default use an array provided for @arbrandes what do you thing? In that way we can get rid of |
1e1f82c
to
d83e228
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 86.71% 87.33% +0.61%
==========================================
Files 48 50 +2
Lines 1393 1429 +36
Branches 293 303 +10
==========================================
+ Hits 1208 1248 +40
+ Misses 172 168 -4
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/i18n/languageManager.js
Outdated
const formData = new FormData(); | ||
formData.append('language', languageCode); | ||
|
||
const url = `${getConfig().LMS_BASE_URL}/i18n/setlang/`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was digging a little bit in edx-platform to see how the mako templates manage the logic and I found this endpoint, it is used for update no-authenticated users as you can see in the mako template.
The endpoint request a CSRF token as you can see here. I just want to make sure the following line of code is correct as a suggested change from the frontend-platform perspective (getAuthenticatedHttpClient
is the right service to use? -@arbrandes could you help me with this doubt?-).
getAuthenticatedHttpClient().patch(`${getConfig().LMS_BASE_URL}/lang_pref/update_language`, {"pref-lang": languageCode}, { isPublic: true })
In this way we can avoid setting the language cookie (as currently happen with the lines 81-83 of the this PR), and it will be 100% managed for the backend in both authenticated and unauthenticated users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I create a sandbox for testing in learning, and the current endpoint can manage the authenticated and unauthenticated case (I have the problem in my dev environment only)
https://app.pr-1741-1395ab.sandboxes.opencraft.hosting/learning/course/course-v1:Demo+CT01+CT01/home
c.c @arbrandes
Hi @arbrandes, I made some changes to the code as you requested. Please let me know what you think:
and i would like to know your thoughts on @dcoa’s comments!
Thank you so much for your time on this! |
Language Management Module
Description
This PR intents to add a new
LanguageManager
module to standardize language switching functionality. The module provides a new API for handling language changes from any component in the application.Key Features
Implementation Details
New Functions
changeUserSessionLanguage(languageCode)
: Main public function that orchestrates the language change process:updateUserPreferences(username, preferenceData)
: Updates server-side user language preferences via the APIsetSessionLanguage(languageCode)
: Sets the language for the current session using the LMS setlang endpointAPI Usage
Components can now implement language switching with a single function call:
Related Work
This functionality is a core dependency for the Language Selector Implementation.