fix: add openedx-atlas as a dependency #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new MFE with tutor and mounting it for development, the image build fails because atlas does not exist atlas has been a necessary part of the image build process since openedx#576 to pull translations.
arbrandes
approved these changes
Apr 29, 2025
Contributor
arbrandes
left a comment
arbrandes
left a comment
There was a problem hiding this comment.
Nice catch, and thank you!
Author
|
@arbrandes Thank you! The checks are failing, it seems I forgot to run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #883 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 7 7
======================================
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new MFE with tutor and mounting it for development, the image build fails because atlas does not exist during the pull_translations step.
Atlas has been a necessary part of the image build process since #576 to pull translations and we now add it as a dependency from start so that the build step does not fail.