Skip to content

feat: include cluster-autoscaler and move chart configurations #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

marbonilla
Copy link

This PR introduces two main changes:

  1. Cluster Autoscaler Installation:
    The chart for deploying cluster-autoscaler is added, along with its proposed configuration in values-example.yaml.

  2. Configuration Reorganization in values.yaml:
    The values.yaml file has been cleaned up to include only the minimum required configuration, making it fully customizable for different needs. The previously defined configuration values have been moved to values-example.yaml. This change addresses issues caused by configuration overrides in the values.

CC @jfavellar90

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 4, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 4, 2025

Thanks for the pull request, @marbonilla!

This repository is currently maintained by @openedx/openedx-k8s-harmony-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@itsjeyd
Copy link

itsjeyd commented Feb 6, 2025

Hey @marbonilla, thank you for this contribution!

The next step will be for you to submit a signed CLA. For details see Submit a signed contributor agreement (CLA) in the bot's comment above.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 6, 2025
@itsjeyd
Copy link

itsjeyd commented Feb 19, 2025

@marbonilla Friendly reminder to follow up on the previous comment ⬆️

@itsjeyd
Copy link

itsjeyd commented Apr 1, 2025

Hey @marbonilla, just checking in to see if you're still planning to continue working on this PR?

@marbonilla marbonilla changed the title feat: include cluster-autoscaler and move chart configuration feat: include cluster-autoscaler and move chart configurations Apr 9, 2025
@marbonilla
Copy link
Author

@openedx/cla-problems
Hi,
I've already signed the necessary documents, but I can't get through the CLA check.
I'm very grateful for your help.

@itsjeyd
Copy link

itsjeyd commented Apr 24, 2025

@marbonilla Looks like the CLA check passed 🎉

Aside from resolving branch conflicts ⬆️, are you planning to make more changes to the code? If not, we can line this PR up for a test run; let me know.

@marbonilla
Copy link
Author

let me know

Hi @itsjeyd, there will be no additional changes for now

@marbonilla marbonilla marked this pull request as ready for review April 28, 2025 19:35
@itsjeyd itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 8, 2025
@itsjeyd
Copy link

itsjeyd commented May 8, 2025

Thanks @marbonilla.

@openedx/openedx-k8s-harmony-maintainers Could you please kick off a build for this PR?

@itsjeyd
Copy link

itsjeyd commented May 19, 2025

@openedx/openedx-k8s-harmony-maintainers

Could you please kick off a build for this PR?

A friendly ping on this ⬆️

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 27, 2025
@e0d e0d moved this from Needs Tests Run or CLA Signed to Ready for Review in Contributions May 27, 2025
@itsjeyd itsjeyd requested a review from a team June 5, 2025 08:22
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 5, 2025
@itsjeyd
Copy link

itsjeyd commented Jun 5, 2025

Hi @openedx/committers-openedx-k8s-harmony, this PR is ready for review now.

. = {"event_id": event_id, "emission_time": format_timestamp!(time,
format: "%+"), "event": encode_json(parsed_json)}

sinks:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the reasoning behind removing the pretty verbose sink configuration, but I believe it should be kept around. For those who are configuring this for the first time, this sink configuration can be relatively complex and would help them to get started.

If we don't want to "pollute" the value examples, then we can create a docs directory in the repo with a README for configuring the sinks and reference that from the value examples. If there is an existing documentation with an example elsewhere, it could be linked instead of creating docs on our own.

@itsjeyd itsjeyd moved this from Ready for Review to In Eng Review in Contributions Jun 12, 2025
@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

7 participants