-
Notifications
You must be signed in to change notification settings - Fork 16
feat: include cluster-autoscaler and move chart configurations #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @marbonilla! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hey @marbonilla, thank you for this contribution! The next step will be for you to submit a signed CLA. For details see Submit a signed contributor agreement (CLA) in the bot's comment above. |
@marbonilla Friendly reminder to follow up on the previous comment ⬆️ |
Hey @marbonilla, just checking in to see if you're still planning to continue working on this PR? |
@openedx/cla-problems |
@marbonilla Looks like the CLA check passed 🎉 Aside from resolving branch conflicts ⬆️, are you planning to make more changes to the code? If not, we can line this PR up for a test run; let me know. |
Hi @itsjeyd, there will be no additional changes for now |
Thanks @marbonilla. @openedx/openedx-k8s-harmony-maintainers Could you please kick off a build for this PR? |
@openedx/openedx-k8s-harmony-maintainers
A friendly ping on this ⬆️ |
Hi @openedx/committers-openedx-k8s-harmony, this PR is ready for review now. |
. = {"event_id": event_id, "emission_time": format_timestamp!(time, | ||
format: "%+"), "event": encode_json(parsed_json)} | ||
|
||
sinks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the reasoning behind removing the pretty verbose sink configuration, but I believe it should be kept around. For those who are configuring this for the first time, this sink configuration can be relatively complex and would help them to get started.
If we don't want to "pollute" the value examples, then we can create a docs
directory in the repo with a README for configuring the sinks and reference that from the value examples. If there is an existing documentation with an example elsewhere, it could be linked instead of creating docs on our own.
This PR introduces two main changes:
Cluster Autoscaler Installation:
The chart for deploying cluster-autoscaler is added, along with its proposed configuration in
values-example.yaml
.Configuration Reorganization in
values.yaml
:The values.yaml file has been cleaned up to include only the minimum required configuration, making it fully customizable for different needs. The previously defined configuration values have been moved to
values-example.yaml
. This change addresses issues caused by configuration overrides in the values.CC @jfavellar90