fix: enzyme testing replaced by react tester

[jciasenza]

Replaced enzyme display dropdown on toggling dropdown test in Main file for react-renderer tests.

I made PR of this issue #35245

And Testing OK

If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)

Developer Checklist

Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review

[openedx-webhooks]

Thanks for the pull request, @jciasenza!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[brian-smith-tcril]

Thanks for this! It's awesome to see enzyme tests replaced!

Would it be possible to use userEvent instead of fireEvent for these? It is recommended by testing-library, and the differences are described here: https://testing-library.com/docs/user-event/intro/#differences-from-fireevent

fireEvent dispatches DOM events, whereas user-event simulates full interactions, which may fire multiple events and do additional checks along the way.

A lot of the time moving to userEvent from fireEvent is very straightforward. It looks like that is likely the case here.

[jciasenza]

Hi @brian-smith-tcril, I'll try it and let you know!!
I made the change, please review !!!

[kdmccormick]

@jciasenza , it looks like the edited test case is failing. If you click into "Javascript tests / JS" check below, you should be able to see how it is failing. If you have a development environment set up, you could also run the tests locally with jest.

[brian-smith-tcril]

It looks like the error is

    Cannot find module '@testing-library/react' from 'lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.test.jsx'

so I think adding the testing library packages as dev dependencies should resolve this.

[jciasenza]

Yes @brian-smith-tcril , that is the error but apparently the version of React is 16 and I am looking for the compatible version for @testing-library/react and @testing-library/user-event

[brian-smith-tcril]

Yes @brian-smith-tcril , that is the error but apparently the version of React is 16 and I am looking for the compatible version for @testing-library/react and @testing-library/user-event

From https://www.npmjs.com/package/@testing-library/react/v/14.3.1

React Testing Library versions 13+ require React v18. If your project uses an older version of React, be sure to install version 12

[jciasenza]

I am closing this pr due to too many commies with many conflicts, I will try to make a new one, cleaner

[jciasenza]

@brian-smith-tcril, @kdmccormick I have made a new PR that now passes the tests #36159 , when you can look at it