-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rejected proposal the fuzzy strings #2128
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
a2023ce
to
c579c07
Compare
c579c07
to
0f23139
Compare
cc: @shadinaif |
8599611
to
0db8699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I left a few suggestions (they look bigger than they are because of manual newlines).
Thank you so much for documenting this!
implementation: `mark invalid entries as fuzzy | FC-0012`_. | ||
|
||
|
||
Proposed Design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a little odd to me for this to come after the rejection section. Maybe it makes sense to move it up to be the first subsection under "Rejected Alternative"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brian-smith-tcril for the review!!
The reason, I did that is that I wanted it to be clear that this design is rejected.
If it's not a blocker, I'd like to merge it after adding the other suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured having it under the "Rejected Alternative: Mark invalid entries as fuzzy" header would communicate that, but I'm fine either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reorganized it. Thanks again!!
886e4e2
to
e0a6435
Compare
Co-authored-by: Brian Smith <[email protected]>
e0a6435
to
7243932
Compare
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This adds an ADR for the rejected proposal of the #1944 pull request. Full details in the other pull request.
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.