-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update community PR comment message slightly to remove duplication #333
fix: Update community PR comment message slightly to remove duplication #333
Conversation
Thanks for the pull request, @xitij2000! This repository is currently maintained by @feanil. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 38 38
Lines 3009 3009
Branches 227 227
=======================================
Hits 2694 2694
Misses 283 283
Partials 32 32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xitij2000 Thanks for the follow-up.
Not related to the changes here, but looking at the new message above I happened to notice a stray horizontal rule that would be worth removing before merging this PR.
Otherwise, LGTM! 👍
-
I tested this:N/A - I read through the code
-
I checked for accessibility issuesN/A - Includes documentation
-
Added to the Code Drift project board (for backports)N/A
Is this ready for review or are y'all still iterating? I noticed it's still in draft. |
Just wanted to add a description before putting it for review 🙂. I might make another small PR to reduce the spacing between the collapsible sections. |
This PR makes slight adjustments to the language that make it work better and sounds less repetitive after the recent changes to the structure of the message.