Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update community PR comment message slightly to remove duplication #333

Merged

Conversation

xitij2000
Copy link
Contributor

@xitij2000 xitij2000 commented Jan 16, 2025

This PR makes slight adjustments to the language that make it work better and sounds less repetitive after the recent changes to the structure of the message.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 16, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 16, 2025

Thanks for the pull request, @xitij2000!

This repository is currently maintained by @feanil.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (4e2da26) to head (186367b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          38       38           
  Lines        3009     3009           
  Branches      227      227           
=======================================
  Hits         2694     2694           
  Misses        283      283           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@itsjeyd itsjeyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xitij2000 Thanks for the follow-up.

Not related to the changes here, but looking at the new message above I happened to notice a stray horizontal rule that would be worth removing before merging this PR.

horizontal-rule

Otherwise, LGTM! 👍

  • I tested this: N/A
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation
  • Added to the Code Drift project board (for backports) N/A

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jan 16, 2025
@itsjeyd itsjeyd requested a review from feanil January 16, 2025 10:06
@feanil
Copy link
Contributor

feanil commented Jan 17, 2025

Is this ready for review or are y'all still iterating? I noticed it's still in draft.

@xitij2000
Copy link
Contributor Author

xitij2000 commented Jan 18, 2025

Is this ready for review or are y'all still iterating? I noticed it's still in draft.

Just wanted to add a description before putting it for review 🙂.

I might make another small PR to reduce the spacing between the collapsible sections.

@xitij2000 xitij2000 marked this pull request as ready for review January 18, 2025 03:08
@feanil feanil merged commit 143140d into openedx:master Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants