Test out how to fix most complaints of Codacy #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be caught by our tests or `tox -e check` runs, which currently don't use pylint. Since pylint is only run via code quality checking platforms, it's ran in as without installing the package under test so getting import errors is normal.
For some reason Codacy still mentions issues found via Prospector's pylint integration, even though I disabled it in Codacy's settings. That's why I'm trying to disable the errors directly in Prospector's configuration file. Let's see whether Codacy picks this up. Another option would be to disable running pylint through Prospector completely by using ".prospector.yaml". I should try this, should the configuration in this commit not work.
Apparently they are unnecessary because pylint also picks up the option without them present.
The message codes where missing a leading "D".
Codecov Report
@@ Coverage Diff @@
## dev #57 +/- ##
=======================================
Coverage 63.05% 63.05%
=======================================
Files 11 11
Lines 157 157
Branches 8 8
=======================================
Hits 99 99
Misses 57 57
Partials 1 1 Continue to review full report at Codecov.
|
According to Codacy's documentation, '.prospector.yaml' is legal, but since it also displays a notification that it doesn't find a configuration file for Prospector, I'm trying other variants. Using ".yml" as the extension is the first.
gnn
force-pushed
the
fixes/#56-fix-codacy-issues
branch
from
daed087
to
25a733c
Compare
Since the bitshift operators are usually side effect free, using them outside of an assignment or something similar looks like a statement without an effect to a static code checker. Using `chain` might remedy this.
khelfen
pushed a commit
that referenced
this pull request
Nov 8, 2024
…taset Add scenario capacities to pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is about testing configuration settings which should disable all of Codacy's complaints which aren't really of interest for us, so that only those ones which actually matter to us and should be fixed are raised.
This would fix #56.