Skip to content

Update watchdogs for function authentication#10

Merged
alexellis merged 2 commits intoopenfaas:masterfrom
welteki:update-watchdogs
Jun 18, 2024
Merged

Update watchdogs for function authentication#10
alexellis merged 2 commits intoopenfaas:masterfrom
welteki:update-watchdogs

Conversation

@welteki
Copy link
Member

@welteki welteki commented Jun 18, 2024

Description

  • Upgrade the classic-watchdog to support built-in function authentication.

  • Create separate build and publish workflows

    • Prevent failing CI for PRs bacause of missing permission to push
      images.
    • Prevent image builds from users with sufficient permission to get
      published on PRs and branches other than master.

Motivation and context

Support enabling built-in authentication for store functions.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
@welteki welteki force-pushed the update-watchdogs branch 2 times, most recently from d553776 to 38e6415 Compare June 18, 2024 13:20
- Prevent failing CI for PRs bacause of missing permission to push
  images.
- Prevent image builds from users with sufficient permission to get
  published on PRs and branches other than master.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
@welteki welteki force-pushed the update-watchdogs branch from 38e6415 to 2a0a9d5 Compare June 18, 2024 13:54
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 3da4274 into openfaas:master Jun 18, 2024
@welteki welteki deleted the update-watchdogs branch June 19, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants