Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --no-pretty global flag to commands #362

Closed
wants to merge 0 commits into from

Conversation

Siddhant-K-code
Copy link
Contributor

@Siddhant-K-code Siddhant-K-code commented Jul 9, 2024

Description

This PR adds a new global flag --no-pretty to various commands. This flag allows users to disable pretty features like emojis, statuses, and progress bars in the command output. The flag is set to false by default.

References

fixes #361

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris
Copy link
Member

👋🏻 Apologies for our delay here @Siddhant-K-code (and extra apologies for the conflicts I caused from a different PR 😅), I was wondering if rather than defining this on each command, we could define this as a global flag that's registered on the root command. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants